Fix/sonor cloud issue 7

[TakanoTaiga]

Description

Abstract

This PR includes modifications based on the results of static analysis performed by SonarCloud. Please refer to the SonarCloud reference for details on the issue fixes.

Background

N/A

Details

N/A

References

Pass large object by reference to const.

• https://sonarcloud.io/project/issues?open=AZJS0wqNtJsnZH2iyX9v&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wqNtJsnZH2iyX9w&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wqNtJsnZH2iyX9x&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wqNtJsnZH2iyX9y&id=tier4_scenario_simulator_v2

Directly pass the arguments for object creation to this function.

• https://sonarcloud.io/project/issues?open=AZJS0wqxtJsnZH2iyX93&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wqxtJsnZH2iyX94&id=tier4_scenario_simulator_v2

Remove this redundant cast.

• https://sonarcloud.io/project/issues?open=AZJS0wp2tJsnZH2iyX9n&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZINWTITjvEq9OQMnMAp&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZINWTITjvEq9OQMnMAq&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wsStJsnZH2iyX-V&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZINWTKTjvEq9OQMnMEt&id=tier4_scenario_simulator_v2

Replace "." with "::" for access

• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7O&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7Q&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7R&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7S&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7T&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7U&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7V&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7W&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7X&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7Y&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7a&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7Z&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7a&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7b&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7d&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7e&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7f&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7g&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7h&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7i&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7j&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7k&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7l&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7m&id=tier4_scenario_simulator_v2
• https://sonarcloud.io/project/issues?open=AZJS0wlVtJsnZH2iyX7n&id=tier4_scenario_simulator_v2

Destructive Changes

N/A

Known Limitations

N/A

[github-actions]

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

• Is this pull request written in a way that is easy to read from a third-party perspective?
• Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
• If this pull request contains a destructive change, does this pull request contain the migration guide?
• Labels of this pull request are valid?
• All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
• The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

[hakuturu583]

Code is LGTM
Start regression test.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
17.2% Coverage on New Code
6.1% Duplication on New Code

See analysis details on SonarQube Cloud