-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor HDMapUtils class about routing graph #1450
Merged
Merged
+278
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in get{Right|Left}LaneletIds
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
HansRobo
added
the
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
label
Nov 14, 2024
hakuturu583
added
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
and removed
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
labels
Nov 18, 2024
hakuturu583
approved these changes
Nov 18, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
wait for regression test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
Background
The current HDMapUtils class uses the vehicle routing graph by default (even for pedestrians).
As the first step to bettter management of routing graph, this pull-request adds RoutingGraphs class.
In addition, the handling of shoulder lanes varies depending on the function, and there is no consistency.
In the future, I plan to develop a unified handling of shoulder lanes by adding a routing graph that includes road shoulders to the better routing graph management added in this pull request.
Details
HDMapUtils::getNextLaneletIds
type
argument to switch routing graph(default:VEHICLE
for backward compatibility)type
argument yet, because it treats road shoulder lanelet.HDMapUtils::getPriviousLaneletIds
type
argument to switch routing graph(default:VEHICLE
for backward compatibility)type
argument yet, because it treats road shoulder lanelet and has a bug.HDMapUtils::getRightLaneletIds
HDMapUtils::getLeftLaneletIds
HDMapUtils::getRoute
HDMapUtils::RoutingGraphs::getRoute
type
argument to switch routing graph(default:VEHICLE
for backward compatibility)References
Regression Test(OK)
Destructive Changes
Although there have been some additions to function arguments, all of this has been carefully implemented to ensure backward compatibility.
Known Limitations