Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor HDMapUtils class about routing graph #1450

Merged
merged 9 commits into from
Nov 18, 2024

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Nov 14, 2024

Description

Abstract

  • add RoutingGraphType enum class to specity types of routing graph
  • add RoutingGraphs class to manage routing graph and paired traffic rule class
  • replace EntityType with RoutingGraphType to specify types of routing graph

Background

The current HDMapUtils class uses the vehicle routing graph by default (even for pedestrians).
As the first step to bettter management of routing graph, this pull-request adds RoutingGraphs class.

In addition, the handling of shoulder lanes varies depending on the function, and there is no consistency.
In the future, I plan to develop a unified handling of shoulder lanes by adding a routing graph that includes road shoulders to the better routing graph management added in this pull request.

Details

  • HDMapUtils::getNextLaneletIds
    • add type argument to switch routing graph(default: VEHICLE for backward compatibility)
    • two overload has not type argument yet, because it treats road shoulder lanelet.
  • HDMapUtils::getPriviousLaneletIds
    • add type argument to switch routing graph(default: VEHICLE for backward compatibility)
      • one overload has not type argument yet, because it treats road shoulder lanelet and has a bug.
  • HDMapUtils::getRightLaneletIds
    • replace EntityType with RoutingGraphType in argument
  • HDMapUtils::getLeftLaneletIds
    • replace EntityType with RoutingGraphType in argument
  • HDMapUtils::getRoute
    • move inplementation into HDMapUtils::RoutingGraphs::getRoute
    • add type argument to switch routing graph(default: VEHICLE for backward compatibility)

References

Regression Test(OK)

Destructive Changes

Although there have been some additions to function arguments, all of this has been carefully implemented to ensure backward compatibility.

Known Limitations

Copy link

github-actions bot commented Nov 14, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@HansRobo HansRobo added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Nov 14, 2024
@HansRobo HansRobo marked this pull request as ready for review November 15, 2024 02:47
@hakuturu583 hakuturu583 added bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 and removed bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 labels Nov 18, 2024
Copy link

sonarcloud bot commented Nov 18, 2024

@hakuturu583 hakuturu583 merged commit 61918b4 into master Nov 18, 2024
13 checks passed
@github-actions github-actions bot deleted the refactor/routing_graph branch November 18, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 wait for regression test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants