-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ByType
element in CollisionCondition
#1423
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
yamacir-kit
requested changes
Oct 24, 2024
openscenario/openscenario_interpreter/src/syntax/by_object_type.cpp
Outdated
Show resolved
Hide resolved
openscenario/openscenario_interpreter/src/syntax/by_object_type.cpp
Outdated
Show resolved
Hide resolved
yamacir-kit
requested changes
Oct 25, 2024
...scenario/openscenario_interpreter/include/openscenario_interpreter/syntax/by_object_type.hpp
Outdated
Show resolved
Hide resolved
...scenario/openscenario_interpreter/include/openscenario_interpreter/syntax/by_object_type.hpp
Outdated
Show resolved
Hide resolved
openscenario/openscenario_interpreter/src/syntax/by_object_type.cpp
Outdated
Show resolved
Hide resolved
openscenario/openscenario_interpreter/src/syntax/by_object_type.cpp
Outdated
Show resolved
Hide resolved
openscenario/openscenario_interpreter/src/syntax/collision_condition.cpp
Outdated
Show resolved
Hide resolved
test_runner/scenario_test_runner/scenario/collision_condition_by_type.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Tatsuya Yamasaki <[email protected]>
Co-authored-by: Tatsuya Yamasaki <[email protected]>
Co-authored-by: Tatsuya Yamasaki <[email protected]>
yamacir-kit
added
feature
New feature or request
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
labels
Nov 8, 2024
Quality Gate passedIssues Measures |
yamacir-kit
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
feature
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
This pull request support
byType
element inCollisionCondition
.Background
Currently, there is no implementation for this element.
Details
This PR contains a new class, ByObjectType.
The given type is converted to entity list and a collision check is performed on them.
There is a new scenario titled "collision_condition_by_type." This scenario tests whether collisions with each type of object are accurately detected. It will pass if collisions are detected between vehicles, between a vehicle and a barricade, and between a vehicle and three pedestrians.
References
None
Destructive Changes
None
Known Limitations
None