Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ByType element in CollisionCondition #1423

Merged
merged 19 commits into from
Nov 14, 2024
Merged

Conversation

abco20
Copy link
Contributor

@abco20 abco20 commented Oct 15, 2024

Description

Abstract

This pull request support byType element in CollisionCondition.

Background

Currently, there is no implementation for this element.

Details

This PR contains a new class, ByObjectType.
The given type is converted to entity list and a collision check is performed on them.

There is a new scenario titled "collision_condition_by_type." This scenario tests whether collisions with each type of object are accurately detected. It will pass if collisions are detected between vehicles, between a vehicle and a barricade, and between a vehicle and three pedestrians.

References

None

Destructive Changes

None

Known Limitations

None

Copy link

github-actions bot commented Oct 15, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@abco20 abco20 marked this pull request as draft October 15, 2024 05:47
@abco20 abco20 marked this pull request as ready for review October 24, 2024 05:30
@yamacir-kit yamacir-kit added feature New feature or request bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 labels Nov 8, 2024
Copy link

sonarcloud bot commented Nov 14, 2024

@yamacir-kit yamacir-kit merged commit 2bc8869 into master Nov 14, 2024
15 checks passed
@github-actions github-actions bot deleted the feature/by_object_type branch November 14, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants