-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize API::getGoalPoses for goal modifications. #1385
Open
TakanoTaiga
wants to merge
7
commits into
master
Choose a base branch
from
feture/customize_get_goal_pose_api_v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
TakanoTaiga
added
the
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
label
Sep 17, 2024
hakuturu583
requested changes
Sep 18, 2024
Please retry analysis of this Pull-Request directly on SonarCloud |
hakuturu583
requested changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
wait for regression test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
This pull request customizes the API::getGoalPoses function for goal modifications in Autoware.
Background
The goal position in Autoware is automatically modified by a feature called "goal modification." This PR addresses the need to retrieve the actual goal positions considering these modifications.
Details
The
API::getGoalPoses
function has been customized to check the goal field in/planning/mission_planning/route
and retrieve the goal positions. WhenAPI::getGoalPoses
is called for an Ego entity, this new logic is applied to extract the correct goal positions. Currently,VehicleEntity::getGoalPoses
is being called, which only computes the route to the goal without considering the goal modifications.References
https://github.com/tier4/sim_evaluation_tools/issues/351
Destructive Changes
N/A
Known Limitations
N/A