[tmp] RJD-1057 (4/5): Remove non-API member functions: EntityManager’s member functions forwarded to EntityBase (2/2)

[TauTheLepton]

Description

DO NOT MERGE | THIS IS A TEMPORARY PR | WHEN THE RIGHT TIME COMES, A CLONE WILL BE CAST TO MASTER

Abstract

This pull request mainly consists of refactoring and introduces changes in the API and EntityManager.

Background

This pull request is an extension of the #1333. ←This will have to be changed!
Due to the fact that these pull requests combined would have been too large for a review, they have been split into two.

Details

As a result of the previous PR, changes have been made to the API and EntityManager classes.
These changes created a great opportunity to declutter / tidy up the code of these classes.
This pull request consists of the code cleanup and refactoring. Many of the changes introduced are just changes to the order of functions inside the implementation file to keep them grouped by functionality and consistent with the header file.

Some other minor changes have been introduced as well, like the addition of the ostream_helpers.cpp.

What is more, the functions EntityManager::spawnEntity and (most importantly) API::spawn have been modified to return the Entity object pointer:

scenario_simulator_v2/simulation/traffic_simulator/include/traffic_simulator/api/api.hpp

Lines 110 to 114 in c9057f9

	template <typename PoseType, typename ParamsType>
	auto spawn(
	const std::string & name, const PoseType & pose, const ParamsType & parameters,
	const std::string & behavior = "", const std::string & model3d = "")
	-> std::shared_ptr<entity::EntityBase>

This change has been applied in the whole codebase, which includes multiple cpp mock scenarios.

References

INTERNAL LINK

Destructive Changes

Known Limitations

[sonarcloud]

Quality Gate passed

Issues
18 New issues
0 Accepted issues

Measures
0 Security Hotspots
55.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud