Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add if section in the restore branch step of the Release action #1248

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

hakuturu583
Copy link
Collaborator

@hakuturu583 hakuturu583 commented May 10, 2024

Description

Abstract

Fixed a bug that caused release actions to fail when an external contributor opened a pull request from a forked repository.

Background

This step is intended to restore a branch that was inadvertently deleted at the same time as a merge, and is set up so that it can work even if there is an operational error.
However, when a pull request is received from an external repository, the branch to be restored does not exist and an error occurs.

Details

I introduced an option to ignore the error so that pull requests from external repositories can be merged.

References

#1242

Destructive Changes

N/A

Known Limitations

N/A

@hakuturu583 hakuturu583 added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label May 10, 2024
@hakuturu583 hakuturu583 self-assigned this May 10, 2024
Copy link

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@hakuturu583 hakuturu583 changed the title add if section restore branch step in Release action add if in restore branch step of Release action May 10, 2024
@hakuturu583 hakuturu583 changed the title add if in restore branch step of Release action add if section in restore branch step of Release action May 10, 2024
@hakuturu583 hakuturu583 changed the title add if section in restore branch step of Release action add if section in the restore branch step of the Release action May 10, 2024
Signed-off-by: hakuturu583 <[email protected]>
@hakuturu583 hakuturu583 requested a review from HansRobo May 10, 2024 06:14
@hakuturu583 hakuturu583 marked this pull request as ready for review May 10, 2024 06:14
@hakuturu583 hakuturu583 marked this pull request as draft May 10, 2024 06:30
@hakuturu583 hakuturu583 marked this pull request as ready for review May 14, 2024 01:21
@hakuturu583 hakuturu583 marked this pull request as draft May 14, 2024 03:11
@HansRobo
Copy link
Member

I would appreciate it if you could work on this PR in your spare time.
(Every morning, I get a notification from GitHub to review this.)

Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Copy link

sonarcloud bot commented Sep 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants