-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hesai): set PTP lock offset on sensor configuration #239
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Max SCHMELLER <[email protected]>
Signed-off-by: Max SCHMELLER <[email protected]>
…d ROS2 wrapper Signed-off-by: Max SCHMELLER <[email protected]>
Signed-off-by: Max SCHMELLER <[email protected]>
… AT128 Signed-off-by: Max SCHMELLER <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
==========================================
- Coverage 26.11% 26.07% -0.05%
==========================================
Files 101 101
Lines 9212 9230 +18
Branches 2211 2212 +1
==========================================
+ Hits 2406 2407 +1
- Misses 6417 6434 +17
Partials 389 389
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Evaluation
Here is a demo of OT128: ptp-lock-offset.mp4It has been confirmed that by restarting Nebula, for a brief moment, the setting can revert to the old value (Hesai firmware bug or PTC documentation inaccurate). With this PR, it is immediately set to the desired value again. |
PR Type
Related Links
Description
This PR adds support for the
SET_PTP_LOCK_OFFSET
andGET_PTP_LOCK_OFFSET
PTC commands.In the inquiry linked above, it was observed that not explicitly setting PTP lock offset sometimes causes the value to reset to
1 us
on at least OT128. While this is likely a sensor firmware bug, being able to set this offset from within Nebula should improve usability, and should eliminate the need to use Hesai's web interface or desktop GUI.PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks