Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add frame_id and sensor_ip as continental launch args #209

Closed
wants to merge 1 commit into from

Conversation

muraki-t4
Copy link

@muraki-t4 muraki-t4 commented Oct 16, 2024

PR Type

  • Bug Fix

Related Links

Description

continental_launch_all_hw.xml is not acceptable frame_id and sensor_ip args, so frame_id and sensor_ip of all radars are same.

Review Procedure

launch continental_launch_all_hw.xml with frame_id and sensor_ip args.

Remarks

I have confirmed that fixed launch file is working on vehicle.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (668c8f7) to head (5543f94).

❗ There is a different number of reports uploaded between BASE (668c8f7) and HEAD (5543f94). Click for more details.

HEAD has 14 uploads less than BASE
Flag BASE (668c8f7) HEAD (5543f94)
total 14 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #209       +/-   ##
==========================================
- Coverage   25.76%   0.00%   -25.77%     
==========================================
  Files          99      86       -13     
  Lines        8755    7628     -1127     
  Branches     2204     930     -1274     
==========================================
- Hits         2256       0     -2256     
- Misses       6114    7628     +1514     
+ Partials      385       0      -385     
Flag Coverage Δ
differential 0.00% <ø> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knzo25 knzo25 removed the request for review from vividf October 16, 2024 07:58
@knzo25
Copy link
Collaborator

knzo25 commented Oct 16, 2024

@muraki-t4
The current nebula does not load parameters this way.
Please have a look at how the lidars do now. For example, take a loook at hesai_OT128.launch.xml.
Like I explained previously, the launcher was made for an older nebula. The steps to take here are to update the radar launchers, not to modify nebula

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants