Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Reorganize Connect SDK documentation structure and UI #5816

Merged

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Dec 19, 2024

Problem solved

Fixes TOOL-2530
Fixes TOOL-2791


PR-Codex overview

This PR focuses on updating references to wallet support from 350+ to 500+ across various components and documentation, enhancing the clarity of the SDK's capabilities. Additionally, it makes adjustments to the sidebar and page content for better organization and user experience.

Detailed summary

  • Updated title of ArticleIconCard from "Live Playground" to "Try the demo".
  • Increased wallet support description from "350+" to "500+" in multiple files.
  • Removed Storage SDK link from the sidebar.
  • Added Accounts & Wallets link to the sidebar.
  • Updated various descriptions and titles to reflect the increased wallet support.
  • Revised layout and content structure for better user navigation and clarity.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: 978fb26

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 0:26am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Dec 20, 2024 0:26am
thirdweb-www ⬜️ Skipped (Inspect) Dec 20, 2024 0:26am
wallet-ui ⬜️ Skipped (Inspect) Dec 20, 2024 0:26am

@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 19, 2024 23:47 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 19, 2024 23:47 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 19, 2024 23:47 Inactive
Copy link
Member Author

joaquim-verges commented Dec 19, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Dec 19, 2024
@joaquim-verges joaquim-verges marked this pull request as ready for review December 19, 2024 23:47
@joaquim-verges joaquim-verges requested review from jakubkrehel and a team as code owners December 19, 2024 23:47
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 19, 2024 23:50 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 19, 2024 23:50 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 19, 2024 23:50 Inactive
@joaquim-verges joaquim-verges force-pushed the docs_Remove_duplicate_contract_section_heading branch from 2040277 to e6a93da Compare December 19, 2024 23:51
@joaquim-verges joaquim-verges force-pushed the docs_Reorganize_Connect_SDK_documentation_structure_and_UI branch from a81a48c to abcfc13 Compare December 19, 2024 23:52
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 19, 2024 23:52 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 19, 2024 23:52 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 19, 2024 23:52 Inactive
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.34%. Comparing base (3d6e2a2) to head (978fb26).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5816   +/-   ##
=======================================
  Coverage   53.34%   53.34%           
=======================================
  Files        1101     1101           
  Lines       59124    59124           
  Branches     4824     4824           
=======================================
  Hits        31541    31541           
  Misses      26864    26864           
  Partials      719      719           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from e6a93da
packages 50.56% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.02 KB (0%) 901 ms (0%) 910 ms (+41.37% 🔺) 1.9 s
thirdweb (cjs) 110.76 KB (0%) 2.3 s (0%) 1.6 s (-13.73% 🔽) 3.8 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 35 ms (-2.36% 🔽) 147 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 59 ms (+117.39% 🔺) 69 ms
thirdweb/react (minimal + tree-shaking) 19.1 KB (0%) 383 ms (0%) 155 ms (-12.5% 🔽) 537 ms

@joaquim-verges joaquim-verges force-pushed the docs_Reorganize_Connect_SDK_documentation_structure_and_UI branch from abcfc13 to 978fb26 Compare December 20, 2024 00:19
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 20, 2024 00:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 20, 2024 00:20 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 20, 2024 00:20 Inactive
Base automatically changed from docs_Remove_duplicate_contract_section_heading to main December 20, 2024 00:20
Comment on lines +63 to +71
client={client}
accountAbstraction={{
chain: base,
sponsorGas: true,
overrides: {
tokenPaymaster: TokenPaymaster.BASE_USDC,
},
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The React code example has a syntax error - there is an extra semicolon before the closing parenthesis. The last line should be }) instead of });.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Copy link

linear bot commented Dec 20, 2024

Copy link

linear bot commented Dec 20, 2024

@joaquim-verges joaquim-verges merged commit 00af0ed into main Dec 20, 2024
30 of 33 checks passed
@joaquim-verges joaquim-verges deleted the docs_Reorganize_Connect_SDK_documentation_structure_and_UI branch December 20, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant