Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove duplicate contract section heading #5815

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Dec 19, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on updating the documentation for sending a generic contract call in the page.mdx file, specifically enhancing the clarity of the section.

Detailed summary

  • Removed the header ## Generic Contract Read.
  • Added a new header ## Sending a generic contract call.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 0:02am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Dec 20, 2024 0:02am
thirdweb-www ⬜️ Skipped (Inspect) Dec 20, 2024 0:02am
wallet-ui ⬜️ Skipped (Inspect) Dec 20, 2024 0:02am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 19, 2024 23:47 Inactive
Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: e6a93da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui December 19, 2024 23:47 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 19, 2024 23:47 Inactive
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Dec 19, 2024
@joaquim-verges joaquim-verges marked this pull request as ready for review December 19, 2024 23:47
@joaquim-verges joaquim-verges requested review from jakubkrehel and a team as code owners December 19, 2024 23:47
Copy link
Contributor

github-actions bot commented Dec 19, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.02 KB (0%) 901 ms (0%) 3.8 s (+22.3% 🔺) 4.7 s
thirdweb (cjs) 110.76 KB (0%) 2.3 s (0%) 6 s (-13.65% 🔽) 8.2 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 244 ms (+13.52% 🔺) 355 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 164 ms (+23.45% 🔺) 174 ms
thirdweb/react (minimal + tree-shaking) 19.1 KB (0%) 383 ms (0%) 833 ms (-0.65% 🔽) 1.3 s

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.34%. Comparing base (3d6e2a2) to head (e6a93da).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5815   +/-   ##
=======================================
  Coverage   53.34%   53.34%           
=======================================
  Files        1101     1101           
  Lines       59124    59124           
  Branches     4824     4824           
=======================================
  Hits        31541    31541           
  Misses      26864    26864           
  Partials      719      719           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 3d6e2a2
packages 50.56% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@joaquim-verges joaquim-verges force-pushed the docs_Remove_duplicate_contract_section_heading branch from 2040277 to e6a93da Compare December 19, 2024 23:51
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 19, 2024 23:52 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 19, 2024 23:52 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 19, 2024 23:52 Inactive
@joaquim-verges joaquim-verges merged commit 1ed2f86 into main Dec 20, 2024
31 of 32 checks passed
@joaquim-verges joaquim-verges deleted the docs_Remove_duplicate_contract_section_heading branch December 20, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant