Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Refactor: More Viem to Ox migration #5790

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

lint

45af357
Select commit
Loading
Failed to load commit list.
Open

[SDK] Refactor: More Viem to Ox migration #5790

lint
45af357
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 18, 2024 in 0s

52.99% (-0.03%) compared to 7d8566e, passed because coverage increased by 0% when compared to adjusted base (53.00%)

View this Pull Request on Codecov

52.99% (-0.03%) compared to 7d8566e, passed because coverage increased by 0% when compared to adjusted base (53.00%)

Details

Codecov Report

Attention: Patch coverage is 71.11111% with 26 lines in your changes missing coverage. Please review.

Project coverage is 52.99%. Comparing base (7d8566e) to head (45af357).

Files with missing lines Patch % Lines
packages/thirdweb/src/auth/verify-signature.ts 31.03% 20 Missing ⚠️
packages/thirdweb/src/auth/verify-hash.ts 54.54% 5 Missing ⚠️
...ages/thirdweb/src/utils/abi/encodeAbiParameters.ts 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5790      +/-   ##
==========================================
- Coverage   53.02%   52.99%   -0.03%     
==========================================
  Files        1101     1102       +1     
  Lines       59080    59150      +70     
  Branches     4810     4809       -1     
==========================================
+ Hits        31328    31349      +21     
- Misses      27034    27083      +49     
  Partials      718      718              
Files with missing lines Coverage Δ
packages/thirdweb/src/auth/is-erc6492-signature.ts 100.00% <100.00%> (ø)
...kages/thirdweb/src/auth/parse-erc6492-signature.ts 100.00% <100.00%> (ø)
packages/thirdweb/src/auth/verify-typed-data.ts 100.00% <100.00%> (ø)
.../src/contract/deployment/utils/create-2-factory.ts 69.23% <100.00%> (+2.71%) ⬆️
...ges/thirdweb/src/extensions/ens/resolve-l2-name.ts 90.90% <100.00%> (+2.02%) ⬆️
...es/thirdweb/src/extensions/erc1155/read/getNFTs.ts 100.00% <100.00%> (ø)
...es/thirdweb/src/extensions/erc1155/write/mintTo.ts 100.00% <100.00%> (ø)
...irdweb/src/extensions/erc1155/write/mintToBatch.ts 93.10% <100.00%> (ø)
...s/thirdweb/src/extensions/erc1155/write/sigMint.ts 95.19% <ø> (ø)
...ons/modules/ClaimableERC1155/setClaimConditions.ts 97.18% <100.00%> (ø)
... and 7 more

... and 4 files with indirect coverage changes