You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Short description of the bug fixed or feature added
PR-Codex overview
This PR primarily updates the imports across multiple files to replace instances of maxUint256 and various utility functions from viem with their counterparts from ox/Solidity and other ox modules, enhancing consistency and potentially improving functionality.
Detailed summary
Changed imports of maxUint256 from viem to ox/Solidity in several files.
Updated isErc6492Signature function to use ox__Hex.slice instead of a local sliceHex.
Modified create2FactoryAddress to use ox__ContractAddress.from.
Adjusted parseErc6492Signature to utilize ox__WrappedSignature.validate and ox__AbiParameters.decode.
Replaced encodePacked from viem with ox__AbiParameters.encodePacked.
Updated various functions to use ox__Hex utilities for hex manipulations.
Altered verifyTypedData to use ox__TypedData for type definitions.
Changed verifyEOASignature to utilize ox__Secp256k1.recoverAddress.
Updated verifyHash to replace signature handling with ox__Signature methods.
Adjusted encodeAbiParameters to use ox__Hex.concat instead of concat from viem/utils.
The following files were skipped due to too many changes: pnpm-lock.yaml
✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gregfromstl
force-pushed
the
greg/viem-ox
branch
from
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR primarily updates the imports across multiple files to replace instances of
maxUint256and various utility functions fromviemwith their counterparts fromox/Solidityand otheroxmodules, enhancing consistency and potentially improving functionality.Detailed summary
maxUint256fromviemtoox/Solidityin several files.isErc6492Signaturefunction to useox__Hex.sliceinstead of a localsliceHex.create2FactoryAddressto useox__ContractAddress.from.parseErc6492Signatureto utilizeox__WrappedSignature.validateandox__AbiParameters.decode.encodePackedfromviemwithox__AbiParameters.encodePacked.ox__Hexutilities for hex manipulations.verifyTypedDatato useox__TypedDatafor type definitions.verifyEOASignatureto utilizeox__Secp256k1.recoverAddress.verifyHashto replace signature handling withox__Signaturemethods.encodeAbiParametersto useox__Hex.concatinstead ofconcatfromviem/utils.