Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Feature: Steam Auth #5415

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Nov 13, 2024

CNCT-2198


PR-Codex overview

This PR introduces Steam as a new authentication option across various components of the application, including updates to types, UI elements, and documentation.

Detailed summary

  • Added Steam to authentication options in ecosystem/types.ts and authentication/types.ts.
  • Updated InAppWalletFormGroup.tsx and ConnectWalletSocialOptions.tsx to include Steam.
  • Added STEAM_ICON for UI representation in multiple files.
  • Updated documentation to reflect Steam in social authentication options.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Nov 13, 2024

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 0:59am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 0:59am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 0:59am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 0:59am

Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: 7b21f1b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

graphite-app bot commented Nov 13, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase. packages labels Nov 13, 2024
Copy link
Contributor

github-actions bot commented Nov 13, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.8 KB (0%) 896 ms (0%) 272 ms (+65.51% 🔺) 1.2 s
thirdweb (cjs) 105.11 KB (0%) 2.2 s (0%) 507 ms (+44.5% 🔺) 2.7 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 33 ms (+102.74% 🔺) 147 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 70 ms (+803.63% 🔺) 80 ms
thirdweb/react (minimal + tree-shaking) 18.79 KB (0%) 376 ms (0%) 106 ms (+71.58% 🔺) 482 ms

@edwardysun
Copy link
Member

changelog

@gregfromstl gregfromstl self-assigned this Nov 15, 2024
@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 15, 2024
Copy link
Member Author

gregfromstl commented Nov 15, 2024

Merge activity

  • Nov 14, 7:35 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 14, 7:43 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 14, 8:00 PM EST: A user merged this pull request with the Graphite merge queue.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 45.52%. Comparing base (f7a4a46) to head (7b21f1b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/thirdweb/src/react/core/utils/walletIcon.ts 60.00% 2 Missing ⚠️
...irdweb/src/wallets/in-app/web/lib/web-connector.ts 0.00% 2 Missing ⚠️
.../web/wallets/shared/ConnectWalletSocialOptions.tsx 0.00% 1 Missing ⚠️
...rdweb/src/react/web/wallets/shared/SocialLogin.tsx 0.00% 1 Missing ⚠️
...irdweb/src/react/web/wallets/shared/oauthSignIn.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5415   +/-   ##
=======================================
  Coverage   45.51%   45.52%           
=======================================
  Files        1071     1070    -1     
  Lines       55700    55682   -18     
  Branches     4030     4029    -1     
=======================================
- Hits        25351    25347    -4     
+ Misses      29662    29648   -14     
  Partials      687      687           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from f7a4a46
packages 40.62% <36.36%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/wallets/types.ts 100.00% <100.00%> (ø)
.../web/wallets/shared/ConnectWalletSocialOptions.tsx 6.89% <0.00%> (-0.02%) ⬇️
...rdweb/src/react/web/wallets/shared/SocialLogin.tsx 1.20% <0.00%> (ø)
...irdweb/src/react/web/wallets/shared/oauthSignIn.ts 4.10% <0.00%> (-0.06%) ⬇️
...ckages/thirdweb/src/react/core/utils/walletIcon.ts 57.95% <60.00%> (+0.12%) ⬆️
...irdweb/src/wallets/in-app/web/lib/web-connector.ts 0.27% <0.00%> (-0.01%) ⬇️

... and 5 files with indirect coverage changes

CNCT-2198

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces `Steam` as a new authentication option across various components and files, enhancing the authentication capabilities of the application.

### Detailed summary
- Added `Steam` as an authentication option in multiple files.
- Updated `types.ts` and `oauthSignIn.ts` to include `Steam`.
- Added `STEAM_ICON` in `svgs.ts` for UI representation.
- Updated connection options in `ConnectWalletMiniPlayground.tsx`.
- Modified documentation to include `Steam` in social logins.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. merge-queue Adds the pull request to Graphite's merge queue. packages Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants