Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #5410

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Version Packages #5410

merged 1 commit into from
Nov 19, 2024

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Nov 13, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

[email protected]

Minor Changes

Patch Changes

@thirdweb-dev/[email protected]

Patch Changes


PR-Codex overview

This PR focuses on updating the versions of @thirdweb-dev/service-utils and thirdweb, along with modifying the CHANGELOG.md files to reflect recent changes, including new features and bug fixes.

Detailed summary

  • Updated @thirdweb-dev/service-utils version from 0.4.48 to 0.4.49.
  • Added entry for version 0.4.49 in CHANGELOG.md for service-utils.
  • Updated thirdweb version from 5.68.0 to 5.69.0.
  • Added entries for version 5.69.0 in CHANGELOG.md for thirdweb, including:
    • Added Steam as an authentication option.
    • Caught localStorage errors.
    • Supported erc6492 signature verification on zksync.
  • Reformatted typesVersions in thirdweb/package.json for clarity.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 6:52pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 6:52pm
thirdweb-www ❌ Failed (Inspect) Nov 19, 2024 6:52pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 6:52pm

Copy link

graphite-app bot commented Nov 13, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.50%. Comparing base (55edd4c) to head (ead6692).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5410      +/-   ##
==========================================
- Coverage   45.52%   45.50%   -0.03%     
==========================================
  Files        1070     1071       +1     
  Lines       55715    55743      +28     
  Branches     4031     4031              
==========================================
  Hits        25367    25367              
- Misses      29661    29689      +28     
  Partials      687      687              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 55edd4c
packages 40.61% <ø> (-0.03%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 2 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Contributor

github-actions bot commented Nov 13, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.9 KB (0%) 899 ms (0%) 303 ms (+122.35% 🔺) 1.3 s
thirdweb (cjs) 105.02 KB (0%) 2.2 s (0%) 421 ms (-4% 🔽) 2.6 s
thirdweb (minimal + tree-shaking) 5.61 KB (0%) 113 ms (0%) 43 ms (+253.9% 🔺) 155 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 10 ms (+196.54% 🔺) 20 ms
thirdweb/react (minimal + tree-shaking) 18.41 KB (0%) 369 ms (0%) 128 ms (+254.09% 🔺) 496 ms

@jnsdls jnsdls force-pushed the changeset-release/main branch from f1c193d to 892702d Compare November 14, 2024 22:52
@jnsdls jnsdls requested a review from gregfromstl as a code owner November 14, 2024 22:52
@jnsdls jnsdls force-pushed the changeset-release/main branch from 892702d to 7d9b50d Compare November 15, 2024 00:42
@jnsdls jnsdls force-pushed the changeset-release/main branch from 7d9b50d to ab673a6 Compare November 15, 2024 01:02
@jnsdls jnsdls force-pushed the changeset-release/main branch from ab673a6 to 5510316 Compare November 15, 2024 01:15
@jnsdls jnsdls force-pushed the changeset-release/main branch from b7f1670 to 56f9116 Compare November 18, 2024 20:03
@jnsdls jnsdls force-pushed the changeset-release/main branch from 56f9116 to e798997 Compare November 18, 2024 20:16
@jnsdls jnsdls force-pushed the changeset-release/main branch from e798997 to 768ef16 Compare November 18, 2024 21:48
@jnsdls jnsdls force-pushed the changeset-release/main branch from 768ef16 to 5e674bb Compare November 18, 2024 22:53
Comment on lines +7 to +9
- [#5415](https://github.com/thirdweb-dev/js/pull/5415) [`7b21f1b`](https://github.com/thirdweb-dev/js/commit/7b21f1b632d65a2bc9bc38656e18d220c6201ed9) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Adds steam auth

- [#5415](https://github.com/thirdweb-dev/js/pull/5415) [`7b21f1b`](https://github.com/thirdweb-dev/js/commit/7b21f1b632d65a2bc9bc38656e18d220c6201ed9) Thanks [@gregfromstl](https://github.com/gregfromstl)! - Adds Steam as an authentication option
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appear to be two identical changelog entries for the Steam authentication feature under the same PR (#5415) and commit. Since these entries describe the same change, one should be removed to maintain a clean and accurate changelog. Consider keeping "Adds Steam as an authentication option" as it's more descriptive than "Adds steam auth".

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant