[Extensions] Enhance ERC20 Drop ClaimCondition functionality #4392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c5b9d1c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org requires the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4392 +/- ##
==========================================
+ Coverage 60.00% 60.03% +0.03%
==========================================
Files 980 982 +2
Lines 80038 80201 +163
Branches 3634 3642 +8
==========================================
+ Hits 48024 48150 +126
- Misses 31335 31372 +37
Partials 679 679
*This pull request uses carry forward flags. Click here to find out more.
|
gregfromstl
approved these changes
Sep 4, 2024
This was referenced Sep 4, 2024
Closed
jnsdls
changed the base branch from
_Update_Refactor_claim_condition_retrieval_and_add_support_check
to
graphite-base/4392
joaquim-verges
approved these changes
Sep 4, 2024
Merge activity
|
jnsdls
force-pushed
the
_Extensions_Enhance_ERC20_Drop_ClaimCondition_functionality
branch
from
cd7d8cf to
54b2c46
Compare
jnsdls
added a commit
that referenced
this pull request
Sep 5, 2024
<!-- start pr-codex -->
## PR-Codex overview
This PR enhances ERC20 Drop ClaimCondition with metadata support and refactors function selectors.
### Detailed summary
- Added `metadata` field to `setClaimConditions` function
- Refactored function selectors for consistency
- Updated `getClaimConditions` to support new changes
> The following files were skipped due to too many changes: `packages/thirdweb/src/extensions/erc20/drops/read/getClaimConditions.ts`, `packages/thirdweb/src/extensions/erc20/drop20.test.ts`
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
jnsdls
force-pushed
the
_Extensions_Enhance_ERC20_Drop_ClaimCondition_functionality
branch
from
54b2c46 to
fa0cf7d
Compare
<!-- start pr-codex -->
## PR-Codex overview
The focus of this PR is to enhance the ERC20 Drop ClaimCondition feature by adding metadata support and improving claim condition retrieval.
### Detailed summary
- Added `metadata` field to `setClaimConditions` function in ERC20 Drop
- Updated function selectors and inputs in ERC20 Drop
- Renamed `ById` to `MultiById` for clarity
- Improved claim condition retrieval logic
- Added support for `resetClaimEligibility` in ERC20 Drop
- Updated exports and imports for clarity
> The following files were skipped due to too many changes: `packages/thirdweb/src/extensions/erc20/drops/read/getClaimConditions.ts`, `packages/thirdweb/src/extensions/erc20/drop20.test.ts`
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
jnsdls
force-pushed
the
_Extensions_Enhance_ERC20_Drop_ClaimCondition_functionality
branch
from
fa0cf7d to
c5b9d1c
Compare
graphite-app
bot
deleted the
_Extensions_Enhance_ERC20_Drop_ClaimCondition_functionality
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR enhances ERC20 Drop ClaimCondition functionality by adding metadata support and refactoring read and write methods.
Detailed summary
metadatafield tosetClaimConditionsinIDropERC20