-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Update] Refactor claim condition retrieval and add support check #4391
[Update] Refactor claim condition retrieval and add support check #4391
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: f9c351c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org requires the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4391 +/- ##
==========================================
+ Coverage 59.95% 59.98% +0.03%
==========================================
Files 978 980 +2
Lines 79759 80024 +265
Branches 3630 3630
==========================================
+ Hits 47818 48005 +187
- Misses 31262 31340 +78
Partials 679 679
*This pull request uses carry forward flags. Click here to find out more.
|
36cc698
to
7148b71
Compare
7148b71
to
9d9c540
Compare
Merge activity
|
) <!-- start pr-codex --> ## PR-Codex overview This PR enhances ERC721 Drop ClaimCondition functionality by adding new methods and improving existing ones. ### Detailed summary - Added `claimCondition` method to `IDrop.json` - Updated `getClaimParams` in `get-claim-params.ts` to use `ZERO_ADDRESS` - Added `isClaimToSupported` and `isLazyMintSupported` functions - Updated `lazyMint` and `claimTo` functions - Added support check functions for various methods > The following files were skipped due to too many changes: `packages/thirdweb/src/extensions/erc721/__generated__/IDrop/read/claimCondition.ts`, `packages/thirdweb/src/extensions/erc721/drops/read/getActiveClaimCondition.ts`, `packages/thirdweb/src/extensions/erc721/drops/read/getClaimConditions.ts`, `packages/thirdweb/src/extensions/erc721/drop721.test.ts` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
9d9c540
to
f9c351c
Compare
PR-Codex overview
This PR enhances ERC721 Drop ClaimCondition functionality and adds support checks for claimTo, lazyMint, setClaimConditions, and resetClaimEligibility methods.
Detailed summary
claimCondition
function to IDrop ABIADDRESS_ZERO
constant toZERO_ADDRESS
claimTo
,lazyMint
,setClaimConditions
, andresetClaimEligibility
methods