Refactor RPC client to use interface #94
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Refactored RPC client interface and updated related components for improved modularity and testability.
What changed?
IRPCClient
interface inrpc.go
to abstract RPC client functionality.Client
struct to implementIRPCClient
interface.Initialize()
function to returnIRPCClient
instead of*Client
.Orchestrator
,ChainTracker
,Committer
,FailureRecoverer
,Poller
,ReorgHandler
, andWorker
to useIRPCClient
interface.GetLatestBlockNumber()
method fromPoller
toClient
.How to test?
Why make this change?
This refactoring improves the codebase by:
IRPCClient
.