-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor data insertion logic #89
Merged
iuwqyir
merged 1 commit into
main
from
10-04-change_main_storage_interface_to_handle_inserts_all_at_once
Oct 10, 2024
Merged
Refactor data insertion logic #89
iuwqyir
merged 1 commit into
main
from
10-04-change_main_storage_interface_to_handle_inserts_all_at_once
Oct 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 4, 2024
iuwqyir
changed the title
change main storage interface to handle inserts all at once
Refactor data insertion logic for improved concurrency and error handling
Oct 4, 2024
iuwqyir
changed the title
Refactor data insertion logic for improved concurrency and error handling
Refactor data insertion logic
Oct 4, 2024
iuwqyir
force-pushed
the
10-04-change_main_storage_interface_to_handle_inserts_all_at_once
branch
from
October 4, 2024 16:46
d0e0f6f
to
4773497
Compare
AmineAfia
reviewed
Oct 7, 2024
AmineAfia
reviewed
Oct 7, 2024
AmineAfia
reviewed
Oct 7, 2024
AmineAfia
approved these changes
Oct 7, 2024
iuwqyir
force-pushed
the
10-04-refactor_rpc_to_a_wrapper_for_easier_reuse
branch
from
October 7, 2024 11:04
5b416ef
to
8663df7
Compare
iuwqyir
force-pushed
the
10-04-change_main_storage_interface_to_handle_inserts_all_at_once
branch
2 times, most recently
from
October 7, 2024 11:44
d06c5d1
to
d0961cb
Compare
iuwqyir
force-pushed
the
10-04-change_main_storage_interface_to_handle_inserts_all_at_once
branch
from
October 7, 2024 13:19
d0961cb
to
b11b079
Compare
AmineAfia
approved these changes
Oct 7, 2024
iuwqyir
force-pushed
the
10-04-refactor_rpc_to_a_wrapper_for_easier_reuse
branch
from
October 7, 2024 20:01
8663df7
to
01aba8e
Compare
iuwqyir
force-pushed
the
10-04-change_main_storage_interface_to_handle_inserts_all_at_once
branch
from
October 7, 2024 20:01
b11b079
to
dd391a7
Compare
This was referenced Oct 8, 2024
iuwqyir
force-pushed
the
10-04-change_main_storage_interface_to_handle_inserts_all_at_once
branch
from
October 8, 2024 23:32
dd391a7
to
ccac684
Compare
iuwqyir
force-pushed
the
10-04-refactor_rpc_to_a_wrapper_for_easier_reuse
branch
from
October 10, 2024 12:48
01aba8e
to
49fe94d
Compare
iuwqyir
force-pushed
the
10-04-change_main_storage_interface_to_handle_inserts_all_at_once
branch
from
October 10, 2024 12:48
ccac684
to
6ead9a7
Compare
iuwqyir
changed the base branch from
10-04-refactor_rpc_to_a_wrapper_for_easier_reuse
to
graphite-base/89
October 10, 2024 14:01
iuwqyir
force-pushed
the
10-04-change_main_storage_interface_to_handle_inserts_all_at_once
branch
from
October 10, 2024 14:02
6ead9a7
to
0f12a69
Compare
iuwqyir
deleted the
10-04-change_main_storage_interface_to_handle_inserts_all_at_once
branch
October 10, 2024 14:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Refactored data insertion process to allow the storage decide how to handle batched data.
E.g sql databases can use transactions and concurrency whereas memory storage can do everything sequentially
What changed?
InsertDataForBlocks
method in theIMainStorage
interface.InsertDataForBlocks
in both ClickHouseConnector and MemoryConnector.InsertDataForBlocks
method instead ofsaveDataToMainStorage
.