Expo Build for PRs #246
Expo Build for PRs #246
Conversation
| run: cd mobile && yarn install | ||
|
|
||
| - name: 🚀 Build app | ||
| run: cd mobile && eas build --platform {{ "${{ inputs.platform }}" }} --profile development --non-interactive |
There was a problem hiding this comment.
Instead of development maybe development_review since the development eas would hold localhost variables instead?
|
🧟 Resurrecting this PR. I've been doing this frequently on a recent project. You've also made a fix I was about to push related to #332 If you don't mind I'll take this over and try to finish it asap. |
…uld be configured over at expo.dev as an EAS Build secret
whusterj
added
the
High Priority
| @@ -50,3 +50,5 @@ jobs: | |||
| env: | |||
| EXPO_PUBLIC_BACKEND_SERVER_URL: {{ "${{ github.event.deployment_status.environment_url }}" }} | |||
| EXPO_PUBLIC_ROLLBAR_ACCESS_TOKEN: "" | |||
| SENTRY_PROJECT_NAME: "" | |||
| SENTRY_DSN: "" | |||
There was a problem hiding this comment.
These Sentry vars are needed, otherwise they will be blank in the eas update JS bundle and cause the app to crash on startup: #332
There was a problem hiding this comment.
Here I've merged a couple ideas from in-progress work from @oudeismetis with the expo-build.yml config from @lakardion — testing this on a project now and will adjust as needed.
There was a problem hiding this comment.
awesome! warms my heart 🙏
| env: | ||
| PR: {{ "${{ steps.findPr.outputs.pr }}" }} | ||
| outputs: | ||
| PR: {{ "${{ env.PR }}" }} |
There was a problem hiding this comment.
If it's a deployment_status event, we don't need to do this as the event itself tells us the PR, URL, etc.
But we might still need this for workflow_dispatch events.
There was a problem hiding this comment.
We still use jwalton/gh-find-current-pr in a bunch of places we don't need to. I have an example on a project or two somewhere showing how to get the value from the deployment event.
What this does
Sometimes you need/want to do a full build test for a PR. Creating a Github Action to do that when manually built.
Checklist
How to test
Add user steps to achieve desired functionality for this feature.