-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile - Add expo workflow yaml for allowing devs to trigger manual builds #349
Conversation
default: "development" | ||
type: choice | ||
# Should match the ones in `eas.json` | ||
options: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this goes nicely with my open PR as well that creates dynamic review app based builds.
I think dynamically adding them to the eas.json like this allows us to create unique builds. In this case as you have it, each engineer's build will overwrite the others (although at this moment many of us don't really need builds that often).
I also wonder if this can be avoided by removing the channel arg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean initially I wrote this because I happened not to have enough permissions in a project to use the eas cli myself so I just used the action to get a build I needed.
This as you said is not something that we would use often, it is just a convenience, mostly to get development builds that we usually need when we deviate from expo go.
with: | ||
expo-version: latest | ||
eas-version: latest | ||
token: ${{ secrets.EXPO_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lakardion - Cookiecutter is trying to render this and failing to 'bake'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, let's see now
EDIT: Actually, scratch that. This is different from #246. I think we're good to merge this in and then I'll continue with #246 separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What this does
With this any dev in the repo can create builds following any given profile from
eas.json
This allows to easily create development builds or staging builds without the need of the dev to have to go through eas CLI in the local.
How to test
Add user steps to achieve desired functionality for this feature.