Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile - Add expo workflow yaml for allowing devs to trigger manual builds #349

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

lakardion
Copy link
Member

What this does

With this any dev in the repo can create builds following any given profile from eas.json

This allows to easily create development builds or staging builds without the need of the dev to have to go through eas CLI in the local.

How to test

Add user steps to achieve desired functionality for this feature.

@oudeismetis oudeismetis temporarily deployed to tn-spa-bootstrapper-pr-349 August 30, 2024 19:24 Inactive
default: "development"
type: choice
# Should match the ones in `eas.json`
options:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this goes nicely with my open PR as well that creates dynamic review app based builds.
I think dynamically adding them to the eas.json like this allows us to create unique builds. In this case as you have it, each engineer's build will overwrite the others (although at this moment many of us don't really need builds that often).
I also wonder if this can be avoided by removing the channel arg

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean initially I wrote this because I happened not to have enough permissions in a project to use the eas cli myself so I just used the action to get a build I needed.
This as you said is not something that we would use often, it is just a convenience, mostly to get development builds that we usually need when we deviate from expo go.

with:
expo-version: latest
eas-version: latest
token: ${{ secrets.EXPO_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lakardion - Cookiecutter is trying to render this and failing to 'bake'.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, let's see now

@oudeismetis oudeismetis temporarily deployed to tn-spa-bootstrapper-pr-349 September 16, 2024 16:38 Inactive
@oudeismetis oudeismetis temporarily deployed to tn-spa-bootstrapper-pr-349 September 16, 2024 16:48 Inactive
@lakardion lakardion requested a review from whusterj September 16, 2024 20:53
@whusterj
Copy link
Member

whusterj commented Nov 12, 2024

This duplicates #246 — I think it's a good idea along with @paribaker's work on dynamic builds for PRs in #340. I'm going to close this PR and move this work over into #246.

EDIT: Actually, scratch that. This is different from #246. I think we're good to merge this in and then I'll continue with #246 separately.

Copy link
Member

@whusterj whusterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whusterj whusterj temporarily deployed to tn-spa-bootstrapper-pr-349 November 12, 2024 18:20 Inactive
@whusterj whusterj merged commit 4bd5523 into main Nov 12, 2024
18 checks passed
@whusterj whusterj deleted the feature/add-expo-build-workflow branch November 12, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants