-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert plugin testing to pipelines #11
Conversation
stages { | ||
stage('Configure Environment') { | ||
steps { | ||
configureRVM(ruby) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be nice as a stage.
|
||
addGem() | ||
databaseFile(gemset()) | ||
configureDatabase(ruby) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be nice as a stage.
steps { | ||
configureRVM(ruby) | ||
deleteDir() | ||
checkout scm: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The git steps could be nice as a stage.
# branch: git repo branch to test, e.g. master | ||
# foreman_branch: foreman git repo branch to run on, e.g. develop | ||
- job-template: | ||
name: 'test_foreman_plugin_{plugin}_{branch}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice here to update to newer naming conventions as part of the shift. I think it would translate to:
foreman-plugin-{plugin}-{branch}-test
foreman-plugin-discovery-develop-test
foreman-plugin-ansible-master-test
foreman-plugin-remote_execution-master-test
default: '{branch}' | ||
description: "Git branch name of the Foreman plugin, e.g. <pre>master</pre>" | ||
- string: | ||
name: plugin_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's odd to me to generate a dedicated job to a plugin and then be able to change the name of the plugin as an input to the job.
- tfm-build-discarder | ||
parameters: | ||
- string: | ||
name: plugin_repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's odd to me to generate a dedicated job to a plugin and then be able to change the repo of the plugin as an input to the job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a job template and this was the easiest way I knew to avoid creating a file to set a variable for every plugin.
default: '{repo}' | ||
description: "Git URL containing the Foreman plugin, e.g. <pre>https://github.com/theforeman/foreman_example</pre>" | ||
- string: | ||
name: plugin_branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's odd to me to generate a dedicated branch job to a plugin and then be able to change the branch being tested of the plugin as an input to the job.
We're migrating to GHA: theforeman/actions#1 |
This is a copy of theforeman/foreman-infra#1227