Refactor Foreman plugins to pipeline plugins #1227
Conversation
| stage('Unit Tests') { | ||
| steps { | ||
| dir('foreman') { | ||
| withRVM(['bundle exec rake jenkins:unit TESTOPTS="-v" --trace'], ruby) |
There was a problem hiding this comment.
Is this really the way to test a plugin?
There was a problem hiding this comment.
I think this will run all tests (including foreman core ones).
For my plugin, I test with rake test:foreman_rh_cloud.
There was a problem hiding this comment.
That's exactly my point, but I think currently this is how we test in Jenkins since I copied the builder.
There was a problem hiding this comment.
So maybe it makes sense to make core tests at least optional? So I will be able to decide for my plugin if I want to run core tests too. For smaller plugins that do not modify core objects it should be OK to run only plugin related tests.
There was a problem hiding this comment.
This is still a draft for now, so this line was partly a TODO so I wouldn't forget.
ekohl
force-pushed
the
plugin-refactor
branch
from
16be77f to
7990f3c
Compare
This is actully a hammer test and not a Foreman plugin test.
ekohl
force-pushed
the
plugin-refactor
branch
from
7990f3c to
e8a5f06
Compare
|
We have moved the Jenkins job definitions over to https://github.com/theforeman/jenkins-jobs -- please re-open your PR against this new repository. |
|
Replaced by theforeman/jenkins-jobs#11 |
This is an effort to remove the workflow jobs in favor of pipelines. Currently still a bit of WIP. It doesn't convert virt-who yet since that needs katello and does some odd things. Also includes some other commits I needed to provision a fresh Jenkins master + slave.