Use theforeman-rubocop gem #188
Merged
+153
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New rubocop version have Lint/ScriptPermission, Rakefile don't need shebang so decided to drop it from here. https://docs.rubocop.org/rubocop/cops_lint.html#lintscriptpermission
We have inherited strictest.yml here, because this rules have NewCops enable config. Also dropped Style/HashSyntax and Style/Documentation from here because that was also included in the inherit file.
chris1984
approved these changes
Mar 20, 2024
|
Thanks @chris1984 for merging it, and @ekohl for helping me out :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have inherited strictest.yml here, because this rules have NewCops
enable config. Also dropped Style/HashSyntax and Style/Documentation
from here because that was also included in the inherit file.
This is part of Rubocop standerdization, link for the reference:
https://community.theforeman.org/t/standardizing-rubocop-with-theforeman-rubocop/37239
https://github.com/theforeman/theforeman-rubocop/?tab=readme-ov-file#all-opinionated-cops-with-new-ones---strictest