Skip to content

Commit

Permalink
Use theforeman-rubocop gem
Browse files Browse the repository at this point in the history
We have inherited strictest.yml here, because this rules have NewCops
enable config. Also dropped Style/HashSyntax and Style/Documentation
from here because that was also included in the inherit file.
  • Loading branch information
archanaserver authored and chris1984 committed Mar 20, 2024
1 parent 6f13fdd commit 621c619
Show file tree
Hide file tree
Showing 4 changed files with 152 additions and 122 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
rubocop:
name: Rubocop
uses: theforeman/actions/.github/workflows/rubocop.yml@v0
with:
command: bundle exec rubocop --parallel --format github

test_ruby:
name: Ruby
Expand Down
14 changes: 3 additions & 11 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,26 +1,18 @@
inherit_from: .rubocop_todo.yml

require:
- rubocop-performance

AllCops:
NewCops: enable
inherit_gem:
theforeman-rubocop:
- strictest.yml

Layout/LineLength:
Enabled: false

Metrics:
Enabled: false

Style/HashSyntax:
EnforcedStyle: no_mixed_keys

Style/SymbolArray:
EnforcedStyle: brackets

Style/Documentation:
Enabled: false

Style/StringLiterals:
Enabled: false

Expand Down
Loading

0 comments on commit 621c619

Please sign in to comment.