Fixes #37746 - Update to pf5 #10272
Open
Fixes #37746 - Update to pf5 #10272
+869
−651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariaAga
commented
Aug 19, 2024
MariaAga
commented
Aug 20, 2024
This was referenced Sep 6, 2024
MariaAga
force-pushed
the
pf5-update
branch
from
d0f6fed
to
1e2fd6f
Compare
kmalyjur
suggested changes
Nov 22, 2024
app/assets/stylesheets/base-pf4.scss
Outdated
There was a problem hiding this comment.
Maybe the first comment could be updated?
webpack/assets/javascripts/react_app/components/HostDetails/Audits/index.js
Outdated
Show resolved
Hide resolved
Comment on lines
61
to
62
| hasNoOffset: false, | ||
| className: undefined, |
There was a problem hiding this comment.
- hasNoOffset is false by default
- is the className necessary?
...ssets/javascripts/react_app/components/HostDetails/Tabs/Details/Cards/TemplatesCard/index.js
Outdated
Show resolved
Hide resolved
...assets/javascripts/react_app/components/HostDetails/Templates/CardItem/CardTemplate/index.js
Outdated
Show resolved
Hide resolved
...sets/javascripts/react_app/components/Layout/components/TaxonomySwitcher/TaxonomyDropdown.js
Show resolved
Hide resolved
webpack/assets/javascripts/react_app/components/PF4/TableIndexPage/Table/Table.js
Outdated
Show resolved
Hide resolved
webpack/assets/javascripts/react_app/components/SearchBar/SearchAutocomplete.js
Outdated
Show resolved
Hide resolved
Comment on lines
+90
to
+104
| return [ | ||
| isDeleteable && { | ||
| title: __('Delete'), | ||
| onClick: () => onDeleteClick({ id, name }), | ||
| isDisabled: !canDelete, | ||
| isAriaDisabled: !canDelete, | ||
| }, | ||
| ...((getActions && | ||
| getActions({ id, name, canDelete, canEdit, ...item })) ?? | ||
| []), | ||
| ...extendActions.map(action => ({ | ||
| ...action, | ||
| isAriaDisabled: action.isDisabled, | ||
| })), | ||
| ].filter(Boolean); | ||
| }; |
There was a problem hiding this comment.
The functionality is fine, however, when opening the table kebab, the "Edit" button looks like it's selected and the mouse on the "Change content..." looks like it's clickable:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs theforeman/foreman-js#481 & to remove pf5 from package.json
Will need plugin updates as well.