review fixes

theforeman · Nov 25, 2024 · 7300ea9 · 7300ea9
1 parent 4823c49
commit 7300ea9
Show file tree

Hide file tree

Showing 10 changed files with 14 additions and 37 deletions.
diff --git a/app/assets/stylesheets/patternfly_colors_overrides.scss b/app/assets/stylesheets/patternfly_colors_overrides.scss
@@ -10,8 +10,13 @@
         color: var(--pf-v5-global--palette--black-500);
       }
       .pf-v5-c-text-input-group__text-input {
-        // color: var(--pf-v5-global--palette--black-500);
         color: var(--pf-v5-global--palette--black-1000);
+        &::placeholder {
+          color: var(--pf-v5-global--palette--black-500);
+        }
+        ::placeholder {
+          color: var(--pf-v5-global--palette--black-500);
+        }
       }
     }
   }

diff --git a/webpack/assets/javascripts/react_app/components/HostDetails/Audits/index.js b/webpack/assets/javascripts/react_app/components/HostDetails/Audits/index.js
@@ -10,13 +10,7 @@ import {
   GridItem,
   Title,
 } from '@patternfly/react-core';
-import {
-  Table /* data-codemods */,
-  TableText,
-  Tr,
-  Tbody,
-  Td,
-} from '@patternfly/react-table';
+import { Table, TableText, Tr, Tbody, Td } from '@patternfly/react-table';
 import URI from 'urijs';
 import { push } from 'connected-react-router';
 

diff --git a/webpack/assets/javascripts/react_app/components/HostDetails/DetailsCard/index.js b/webpack/assets/javascripts/react_app/components/HostDetails/DetailsCard/index.js
@@ -58,8 +58,6 @@ const DetailsCard = ({
               />
             </>
           ),
-          hasNoOffset: false,
-          className: undefined,
         }}
       >
         <CardTitle>{__('Details')}</CardTitle>

diff --git a/...ts/javascripts/react_app/components/HostDetails/Tabs/Details/Cards/TemplatesCard/index.js b/...ts/javascripts/react_app/components/HostDetails/Tabs/Details/Cards/TemplatesCard/index.js
@@ -2,12 +2,7 @@ import React, { useState } from 'react';
 import PropTypes from 'prop-types';
 import { Button } from '@patternfly/react-core';
 import { PencilAltIcon } from '@patternfly/react-icons';
-import {
-  Table /* data-codemods */,
-  Tr,
-  Tbody,
-  Td,
-} from '@patternfly/react-table';
+import { Table, Tr, Tbody, Td } from '@patternfly/react-table';
 import { translate as __ } from '../../../../../../common/I18n';
 import { foremanUrl } from '../../../../../../common/helpers';
 import { useAPI } from '../../../../../../common/hooks/API/APIHooks';

diff --git a/...ck/assets/javascripts/react_app/components/HostDetails/Tabs/Parameters/ParametersTable.js b/...ck/assets/javascripts/react_app/components/HostDetails/Tabs/Parameters/ParametersTable.js
@@ -1,12 +1,6 @@
 import React, { useState } from 'react';
 import PropTypes from 'prop-types';
-import {
-  Table /* data-codemods */,
-  Thead,
-  Tbody,
-  Tr,
-  Th,
-} from '@patternfly/react-table';
+import { Table, Thead, Tbody, Tr, Th } from '@patternfly/react-table';
 import {
   Toolbar,
   ToolbarContent,
@@ -135,7 +129,7 @@ export const ParametersTable = ({
             <Th>{columnNames.type}</Th>
             <Th>{columnNames.value}</Th>
             <Th>{columnNames.source}</Th>
-            <Th aria-label='actions'/>
+            <Th aria-label="actions" />
           </Tr>
         </Thead>
         <Tbody>

diff --git a/webpack/assets/javascripts/react_app/components/HostDetails/Tabs/ReportsTab/ReportsTable.js b/webpack/assets/javascripts/react_app/components/HostDetails/Tabs/ReportsTab/ReportsTable.js
@@ -1,13 +1,6 @@
 import React from 'react';
 import PropTypes from 'prop-types';
-import {
-  Table /* data-codemods */,
-  Thead,
-  Tbody,
-  Tr,
-  Th,
-  Td,
-} from '@patternfly/react-table';
+import { Table, Thead, Tbody, Tr, Th, Td } from '@patternfly/react-table';
 import { Spinner } from '@patternfly/react-core';
 import { SearchIcon, ExclamationCircleIcon } from '@patternfly/react-icons';
 import { STATUS } from '../../../../constants';

diff --git a/...ets/javascripts/react_app/components/HostDetails/Templates/CardItem/CardTemplate/index.js b/...ets/javascripts/react_app/components/HostDetails/Templates/CardItem/CardTemplate/index.js
@@ -80,8 +80,6 @@ const CardTemplate = ({
                   />
                 </>
               ),
-              hasNoOffset: false,
-              className: undefined,
             },
           })}
           onExpand={expandable && onExpandCallback}

diff --git a/...s/javascripts/react_app/components/Layout/components/TaxonomySwitcher/TaxonomyDropdown.js b/...s/javascripts/react_app/components/Layout/components/TaxonomySwitcher/TaxonomyDropdown.js
@@ -44,7 +44,7 @@ const TaxonomyDropdown = ({ taxonomyType, currentTaxonomy, taxonomies }) => {
   const onSelect = () => {
     setIsOpen(!isOpen);
   };
-  const onSearchInputChange = (value, event) => {
+  const onSearchInputChange = event => {
     setSearchValue(event.target.value);
   };
 

diff --git a/webpack/assets/javascripts/react_app/components/PF4/TableIndexPage/Table/Table.js b/webpack/assets/javascripts/react_app/components/PF4/TableIndexPage/Table/Table.js
@@ -1,7 +1,7 @@
 import React, { useState } from 'react';
 import PropTypes from 'prop-types';
 import {
-  Table as PFTable /* data-codemods */,
+  Table as PFTable,
   Thead,
   Tr,
   Th,

diff --git a/webpack/assets/javascripts/react_app/components/SearchBar/AutoCompleteMenu.js b/webpack/assets/javascripts/react_app/components/SearchBar/AutoCompleteMenu.js
@@ -48,7 +48,7 @@ export const AutoCompleteMenu = ({ results, error }) => {
     .map(category => (
       <Fragment key={`${category}-fragment`}>
         {!!itemIndex && <Divider key={`${category}-divider`} />}
-        <MenuGroup label={category} key={category}>
+        <MenuGroup label={category || null} key={category}>
           <MenuList>{getMenuItemsByCategory(category)}</MenuList>
         </MenuGroup>
       </Fragment>