Split the project into WebDriver and WinAppDriver modules #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdav
approved these changes
Oct 23, 2023
tristanlabelle
force-pushed
the
tristan/WinAppDriver-module
branch
from
77fca85
to
990ecc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WebDrivermodule is cross-platform whereas theWinAppDrivermodule has dependencies on Windows.There is one unfortunate dependency where the base
WebDrivermodule needs thewinAppDriver_elementNotInteractableconstant in its retrying logic (or maybe it doesn't? we should revisit whether we need to special-case this error).