Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a mechanism to handle per-platform differences. #55

Closed
jeffdav opened this issue Aug 4, 2023 · 4 comments
Closed

Need a mechanism to handle per-platform differences. #55

jeffdav opened this issue Aug 4, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@jeffdav
Copy link
Contributor

jeffdav commented Aug 4, 2023

Specifically, we define custom error codes for WinAppDriver, but those same codes could mean different things on platforms targeting different engines. We should handle platform specific errors in some sort of "what platform am I on?" block.

@jeffdav jeffdav added the enhancement New feature or request label Aug 4, 2023
@tristanlabelle
Copy link
Contributor

@jeffdav Could we say that #115 completes this (if we merge it)?

@jeffdav
Copy link
Contributor Author

jeffdav commented Oct 23, 2023

Not quite, because, as you noted in your diff, there's a WAD-specfiic error code. We need some way of delegating the "what errors should trigger a retry" out to platform specific modules.

@jeffdav
Copy link
Contributor Author

jeffdav commented Oct 23, 2023

But #115 is a great start!

@tristanlabelle
Copy link
Contributor

#150 did complete this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants