Add reliable engine binary retrieval

.github/workflows/client-build-tool.yml

@@ -96,6 +96,12 @@ on:
       custom-project-file:
         required: false
         type: string
+      editor-download-url:
+        required: true
+        type: string
+      template-download-url:
+        required: true
+        type: string
     outputs:
       url:
         value: ${{ jobs.client-build-tool.outputs.url }}
@@ -158,27 +164,16 @@ jobs:
           rm -Rf project.godot
           mv ${{ inputs.custom-project-file }} project.godot
 
-      - name: Download editor artifact
-        uses: dawidd6/action-download-artifact@v3
-        with:
-          github_token: ${{ secrets.cicd-token-github }}
-          workflow: ${{ inputs.editor-binary-workflow }}
-          workflow_conclusion: "in_progress"
-          name: ${{ inputs.editor-binary-download }}
+      - name: Download editor and template
+        run: |
+          curl ${{ inputs.editor-download-url }} > ${{ inputs.editor-binary-download }}
+          curl ${{ inputs.template-download-url }} > ${{ inputs.template-binary-name }}
 
       - name: Unzip editor binary
         if: ${{ inputs.should-unzip-editor }}
         run: |
           unzip -o ${{ inputs.editor-binary-download }}
 
-      - name: Download export template artifact
-        uses: dawidd6/action-download-artifact@v3
-        with:
-          github_token: ${{ secrets.cicd-token-github }}
-          workflow: ${{ inputs.template-binary-workflow }}
-          workflow_conclusion: "in_progress" # must be in_progress otherwise we can't find them for our current job 
-          name: ${{ inputs.template-binary-name }}
-
       - name: Set up template in system-wide editor data
         run: |
           chmod +x ./${{ inputs.template-binary-name }}

.github/workflows/deployment-pr.yml

@@ -0,0 +1,98 @@
+name: PR Deployment
+on:
+  pull_request:
+    paths:
+    - godot-engine/**
+    - .github/**
+    - mirror-godot-app/**
+
+concurrency:
+  # workflow name - PR || fallback to unique run id, this happens when you're not building a PR
+  # this ensures all branches build properly and cancel their previous runs
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  build-windows-client:
+    name: 🏁 Build Windows Dev PR
+    uses: ./.github/workflows/client-build-tool.yml
+    secrets:
+      gcp-secret: ""
+      cicd-token-github: ${{ secrets.GITHUB_TOKEN }}
+    with:
+      should-deploy: false
+      should-run-unit-tests: true
+      should-notify-on-failure: false
+      editor-binary-workflow: deployment.yml
+      editor-binary-name: MirrorGodotEditorWindows.exe
+      editor-binary-download: MirrorGodotEditorWindows.exe
+      editor-binary-branch: dev
+      editor-template-directory: ~/AppData/Roaming/Godot/export_templates/4.3.dev
+      template-binary-workflow: deployment.yml
+      template-binary-name: windows_release_x86_64.exe
+      template-binary-branch: themirror
+      export-template-file: windows_release_x86_64.exe
+      game-environment-cfg-name: official
+      game-export-preset: Windows
+      game-binary-name: The Mirror Dev.exe
+      bucket-name: no-bucket
+      os: "windows-latest"
+      # TODO: This will be dynamic in future and we can't do that immediately as we have to focus on the deployment side.
+      editor-download-url: https://storage.googleapis.com/mirror_native_client_builds/Engine/4309e8e8/MirrorGodotEditorWindows.exe
+      template-download-url: https://storage.googleapis.com/mirror_native_client_builds/Engine/4309e8e8/windows_release_x86_64.exe
+  build-macos-client:
+    name: 🍎 Build MacOS Dev PR
+    uses: ./.github/workflows/client-build-tool.yml
+    secrets:
+      gcp-secret: ""
+      cicd-token-github: ${{ secrets.GITHUB_TOKEN }}
+    with:
+      should-deploy: false
+      should-run-unit-tests: true
+      should-notify-on-failure: false
+      should-unzip-editor: true
+      should-install-timeout-macos: true
+      editor-binary-workflow: deployment.yml
+      editor-binary-download: MirrorGodotEditorMac.app.zip
+      editor-binary-name: MirrorGodotEditorMac.app/Contents/MacOS/Godot
+      editor-binary-branch: themirror
+      editor-template-directory: ~/Library/Application\ Support/Godot/export_templates/4.3.dev
+      template-binary-workflow: deployment.yml
+      template-binary-name: macos_template.app.zip
+      template-binary-branch: dev
+      export-template-file: macos.zip
+      game-environment-cfg-name: official
+      game-export-preset: MacOS-themirror-dev
+      game-binary-name: The Mirror Dev.app
+      bucket-name: no-bucket
+      os: "macos-latest"
+      # TODO: This will be dynamic in future and we can't do that immediately as we have to focus on the deployment side.
+      editor-download-url: https://storage.googleapis.com/mirror_native_client_builds/Engine/4309e8e8/MirrorGodotEditorMac.app.zip
+      template-download-url: https://storage.googleapis.com/mirror_native_client_builds/Engine/4309e8e8/macos_template.app.zip
+  build-linux-client:
+    name: 🐧 Build Linux Dev PR
+    uses: ./.github/workflows/client-build-tool.yml
+    secrets:
+      gcp-secret: ""
+      cicd-token-github: ${{ secrets.GITHUB_TOKEN }}
+    with:
+      should-deploy: false
+      should-run-unit-tests: true
+      should-notify-on-failure: false
+      editor-binary-workflow: deployment.yml
+      editor-binary-name: MirrorGodotEditorLinux.x86_64
+      editor-binary-download: MirrorGodotEditorLinux.x86_64
+      editor-binary-branch: dev
+      editor-template-directory: ~/.local/share/godot/export_templates/4.3.dev
+      template-binary-workflow: deployment.yml
+      template-binary-name: linux_release.x86_64
+      template-binary-branch: themirror
+      export-template-file: linux_release.x86_64
+      game-environment-cfg-name: official
+      game-export-preset: Linux
+      game-binary-name: The Mirror Dev.x86_64
+      bucket-name: no-bucket
+      os: "ubuntu-20.04"
+      # TODO: This will be dynamic in future and we can't do that immediately as we have to focus on the deployment side.
+      editor-download-url: https://storage.googleapis.com/mirror_native_client_builds/Engine/4309e8e8/MirrorGodotEditorLinux.x86_64
+      template-download-url: https://storage.googleapis.com/mirror_native_client_builds/Engine/4309e8e8/linux_release.x86_64