Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reliable engine binary retrieval #101

Merged
merged 19 commits into from
Apr 11, 2024

Conversation

RevoluPowered
Copy link
Collaborator

@RevoluPowered RevoluPowered commented Apr 9, 2024

Why?

  • We kept having bugs when ingesting the binaries into github steps, 50 percent of the time it would fail and keep failing or the artefacts were deleted by GitHub.
  • I just implemented a bucket to upload these binaries in GCP as it is 3 times faster, and also always is guaranteed to actually function for our development branch.
  • We're working towards getting a full release out soon.

Changes:

  • Split the engine and the app build into separate files
  • Used composite job for the engine build so we can easily invoke it at the correct phase
  • Upload the binaries to GCP and GitHub artefacts, so that the GCP bucket contains a binary for each engine hash.
  • Add hash checker to ensure builds fail as early as possible if this is missing.
  • Ensure we build the engine before building the app.
  • Format fixes.

Important (ONLY FOR Pull Requests. on the dev branch on the dev branch this is totally automatic):

  • Engine builds must update the Engine / Template hash manually until we make some additional changes to this code

Future:

  • We can re-merge the deployment-pr.yml once we have some simple code to grab the correct engine hash without running the engine.yml file. (right now the editor and template are just static links but only in the PR context)
  • In the engine build context (on the dev branch we can safely upload engine binaries as they have been vetted)

Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
mirror-docs ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2024 4:04pm

@RevoluPowered RevoluPowered force-pushed the gordon/deploy-using-gcp-buckets branch from 54471b9 to 13ef6c2 Compare April 9, 2024 20:26
@RevoluPowered RevoluPowered changed the title split engine and deployment since GHA is not working from the other repo Add reliable engine binary retrieval Apr 11, 2024
We'll fix this in the future to make the step return the hash at a later stage.
@RevoluPowered RevoluPowered marked this pull request as ready for review April 11, 2024 16:08
@RevoluPowered RevoluPowered enabled auto-merge (squash) April 11, 2024 16:13
@RevoluPowered RevoluPowered disabled auto-merge April 11, 2024 16:43
@RevoluPowered RevoluPowered merged commit d457c72 into dev Apr 11, 2024
8 checks passed
@RevoluPowered RevoluPowered deleted the gordon/deploy-using-gcp-buckets branch April 11, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant