-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for player count, uptime, GitHub App authentication, and git credentials validation #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make abstract
Cyberboss
added
Client
Issue with the .NET client library
Feature
New functionality
REST
The JSON REST API for server control
Area: DMAPI
Communication between TGS and DM
Area: Watchdog
With regard to managing DreamDaemon servers
Host Watchdog Change
A change to one of the Host./<Watchdog/Service/Console> projects which do not receive auto updates
Breaking API Change
Requires a major API version bump
labels
Sep 3, 2024
Cyberboss
changed the title
Support for player count, uptime, and GitHub App authentication
Support for player count, uptime, GitHub App authentication, and git credentials validation
Sep 4, 2024
This was referenced Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: DMAPI
Communication between TGS and DM
Area: Watchdog
With regard to managing DreamDaemon servers
Breaking API Change
Requires a major API version bump
Client
Issue with the .NET client library
Feature
New functionality
Host Watchdog Change
A change to one of the Host./<Watchdog/Service/Console> projects which do not receive auto updates
REST
The JSON REST API for server control
size/L
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🆑
GitHub and GitLab credentials for instances are now validated when created/updated.
The host watchdog no longer needs to be launched with a special parameter to enable SystemD interoperability.
/:cl:
🆑 HTTP API
HTTP 424 will be returned during PUT or POST
/api/Repository
if provided credentials are determined to be invalid.Added error code 108 for if a repository
accessToken
was determined to be for a user different toaccessUser
.Repository access credentials can now use GitHub App private keys in a special encoded format:
"TGS_PK_" + (APP_ID OR CLIENT_ID) + ":" + BASE64(APP_PRIVATE_KEY)
(Clients should perform this formatting for users). If this is used, the app name should be set as the username. Required permissions arecontents: read
for cloning,contents: write
for pushing test merge commits,pull_requests: write
for posting test merge comments, andcontents: write
+deployments: write
for enabling GitHub deployments.Added ISO8601
launchTime
field to DreamDaemon response model.Added
clientCount
field to DreamDaemon response model. Requires game side interop version >= 5.10.0 and watchdog health checks to be enabled to function./:cl:
🆑 Nuget: API
BREAKING: Moved
RepositorySettings
out ofInternal
namespace and made abstract.Added TGS encoded app private key prefix to
RepositorySettings
.Added
DreamDaemonApiBase.LaunchTime
.Added
DreamDaemonApiBase.ClientCount
./:cl:
🆑 Nuget: Client
BREAKING: Updated API definitions library to 14.0.0.
/:cl:
🆑 DreamMaker API
Added support for relaying current client count back to TGS during health checks.
/:cl:
Closes #1909
Closes #1858
Closes #1876