Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for player count, uptime, GitHub App authentication, and git credentials validation #1920

Merged
merged 23 commits into from
Sep 4, 2024

Conversation

Cyberboss
Copy link
Member

@Cyberboss Cyberboss commented Sep 3, 2024

🆑
GitHub and GitLab credentials for instances are now validated when created/updated.
The host watchdog no longer needs to be launched with a special parameter to enable SystemD interoperability.
/:cl:

🆑 HTTP API
HTTP 424 will be returned during PUT or POST /api/Repository if provided credentials are determined to be invalid.
Added error code 108 for if a repository accessToken was determined to be for a user different to accessUser.
Repository access credentials can now use GitHub App private keys in a special encoded format: "TGS_PK_" + (APP_ID OR CLIENT_ID) + ":" + BASE64(APP_PRIVATE_KEY) (Clients should perform this formatting for users). If this is used, the app name should be set as the username. Required permissions are contents: read for cloning, contents: write for pushing test merge commits, pull_requests: write for posting test merge comments, and contents: write + deployments: write for enabling GitHub deployments.
Added ISO8601 launchTime field to DreamDaemon response model.
Added clientCount field to DreamDaemon response model. Requires game side interop version >= 5.10.0 and watchdog health checks to be enabled to function.
/:cl:

🆑 Nuget: API
BREAKING: Moved RepositorySettings out of Internal namespace and made abstract.
Added TGS encoded app private key prefix to RepositorySettings.
Added DreamDaemonApiBase.LaunchTime.
Added DreamDaemonApiBase.ClientCount.
/:cl:

🆑 Nuget: Client
BREAKING: Updated API definitions library to 14.0.0.
/:cl:

🆑 DreamMaker API
Added support for relaying current client count back to TGS during health checks.
/:cl:

Closes #1909
Closes #1858
Closes #1876

@Cyberboss Cyberboss added Client Issue with the .NET client library Feature New functionality REST The JSON REST API for server control Area: DMAPI Communication between TGS and DM Area: Watchdog With regard to managing DreamDaemon servers Host Watchdog Change A change to one of the Host./<Watchdog/Service/Console> projects which do not receive auto updates Breaking API Change Requires a major API version bump labels Sep 3, 2024
@Cyberboss Cyberboss added this to the v6.10.0 milestone Sep 3, 2024
@Cyberboss Cyberboss enabled auto-merge September 3, 2024 11:15
tgstation-server-ci[bot]
tgstation-server-ci bot previously approved these changes Sep 3, 2024
@Cyberboss Cyberboss changed the title Support for player count, uptime, and GitHub App authentication Support for player count, uptime, GitHub App authentication, and git credentials validation Sep 4, 2024
tgstation-server-ci[bot]
tgstation-server-ci bot previously approved these changes Sep 4, 2024
This was referenced Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: DMAPI Communication between TGS and DM Area: Watchdog With regard to managing DreamDaemon servers Breaking API Change Requires a major API version bump Client Issue with the .NET client library Feature New functionality Host Watchdog Change A change to one of the Host./<Watchdog/Service/Console> projects which do not receive auto updates REST The JSON REST API for server control size/L
Projects
None yet
1 participant