Automatic TGS DMAPI Update #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
force-pushed
the
tgs-dmapi-update
branch
7 times, most recently
from
65b042a to
10594ab
Compare
StrangeWeirdKitten
pushed a commit
that referenced
this pull request
Dec 28, 2024
…embeds on reagent spears (Bubberstation#2536) ## About The Pull Request This fixes two bugs. Quoting the player reported bug: Exploit #1 - Twitch Next Move modificier This one needs a bit of VV to test mostly to speed up the conditions, but its doable by a miner with a bit of skill. You need the berserker armor of the chosen one, or alternatively, the Dexterous mutation and a way to remove it (I think you can do so with mutadone, but never tried, regardless!) and Twitch. The short of it is that the next move variable is always edited with multiplicatives, but Twitch was coded with an aditive, so alternating one and another and then removing one effect and letting the other run out would net you with a lower than 1 next move variable. Exploit #2 - God Slaying Spear This one is easy to test, basically you all got a spear with better embeed stats than ninja stars, which embeeds most of the time thanks to its high embeed chance, plus its armor penetration, with no chance for it to fall out naturally so it has to be manually removed. Since it has a Bulky weight class, its damage multiplier is 4 plus the pain multiplier being 6, doing 24 damage per tick and on extraction, being able to kill a person that gets it in 10 seconds, even if armored. We had a whole clique abusing this as icecats on nova, and even combining it with morphine. https://github.com/Bubberstation/Bubberstation/blob/master/modular_skyrat/modules/reagent_forging/code/forge_weapons.dm#L136 ## Why It's Good For The Game Fixes some seriously game breaking bugs no one's abused yet, discovered on Nova, ## Proof Of Testing <details> <summary>Screenshots/Videos</summary> </details> ## Changelog :cl: OrbisAnima (code for 1), ReturnToZender (code for 2) fix: Fixes an exploit with Twitch, and the reagent forged spear's embedding. /:cl: --------- Co-authored-by: Arturlang <[email protected]>
github-actions
bot
force-pushed
the
tgs-dmapi-update
branch
8 times, most recently
from
9f981f8 to
6244f5e
Compare
github-actions
bot
force-pushed
the
tgs-dmapi-update
branch
from
6244f5e to
bb95a7c
Compare
StrangeWeirdKitten
force-pushed
the
master
branch
from
ab8ab5f to
a4710ff
Compare
github-actions
bot
force-pushed
the
tgs-dmapi-update
branch
from
bb95a7c to
4a36a79
Compare
StrangeWeirdKitten
force-pushed
the
master
branch
from
af79256 to
43cada9
Compare
github-actions
bot
force-pushed
the
tgs-dmapi-update
branch
8 times, most recently
from
1bd5bbf to
a6dd3e0
Compare
github-actions
bot
force-pushed
the
tgs-dmapi-update
branch
4 times, most recently
from
783109e to
ce76e1c
Compare
github-actions
bot
force-pushed
the
tgs-dmapi-update
branch
from
ce76e1c to
5625eaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the TGS DMAPI to the latest version. Please note any changes that may be breaking or unimplemented in your codebase by checking what changes are in the definitions file: code/__DEFINES/tgs.dm before merging.
Full changelog can be found here.
#tgs-dmapi-release