Fix various problems reported in #1703 #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
s0nx
commented
Mar 21, 2023
•
s0nx
commented
- perform SKB linear data split during http/1 -> http/2 response transformation
- with the attached linux patch, we shouldn't get low-headroom SKBs anymore
const-t
force-pushed
the
kt-1103-h2-msg-trasform
branch
from
33e53dc
to
b8d04c3
Compare
s0nx
changed the title
s0nx
changed the title
const-t
force-pushed
the
kt-1103-h2-msg-trasform
branch
2 times, most recently
from
7f2b22e
to
ea35810
Compare
const-t
requested changes
Apr 4, 2023
krizhanovsky
requested changes
Apr 4, 2023
There was a problem hiding this comment.
The patch introduces a lot of sophisticated code, some of which seems duplicate of existing code, and additional computation complexity reducing performance of any traffic. All of this is just to fix a rare problem. Either an implementation of the idea must be much more polished or we should go with a simpler solution like catch the case wherever we can catch it, log it and close a TCP connection.
const-t
force-pushed
the
kt-1103-h2-msg-trasform
branch
3 times, most recently
from
ca26930
to
0913e9e
Compare
s0nx
force-pushed
the
pv-1703-crash
branch
2 times, most recently
from
8d088ed
to
b87217b
Compare
const-t
requested changes
Apr 11, 2023
krizhanovsky
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
I just don't have anything to add to @const-t and @EvgeniiMekhanik reviews, so I just approve the PR.
http/1 -> http/2 response transformation Signed-off-by: Petr Vyazovik <[email protected]>
Signed-off-by: Petr Vyazovik <[email protected]>
of outgoing SKBs during IPv4 fragmentation to overcome the issue with the lack of space for transport headers Signed-off-by: Petr Vyazovik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.