Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/ipv4/ip_output: Reserve some additional space in headroom of outgoing SKBs during IPv4 fragmentation #11

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

s0nx
Copy link
Contributor

@s0nx s0nx commented Mar 27, 2023

to reflect that it might return transformed sk_buff now

Response transformation is being performed in SKB fragments now,
so do not reserve additional space in headroom

Signed-off-by: Petr Vyazovik <[email protected]>
@s0nx s0nx changed the title tcp_write_xmit: Change sk_write_xmit() signature net/ipv4/ip_output: Reserve some additional space in headroom of outgoing SKBs during IPv4 fragmentation Apr 7, 2023
Copy link
Contributor

@krizhanovsky krizhanovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the code is called only for IP fragmented output, so I'm good with the memory overhead for this case.

However, it looks like we should patch IPv6 code as well.

net/ipv4/tcp_output.c Outdated Show resolved Hide resolved
@@ -701,8 +701,40 @@ struct sk_buff *ip_frag_next(struct sk_buff *skb, struct ip_frag_state *state)
len &= ~7;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we have very similar code in ip6_frag_next() - why don't we patch the IPv6 code as well?

of outgoing SKBs during IPv4 fragmentation to overcome the issue
with the lack of space for transport headers

Signed-off-by: Petr Vyazovik <[email protected]>
@krizhanovsky krizhanovsky merged commit f8d892a into main Apr 13, 2023
@krizhanovsky krizhanovsky deleted the pv-1703-crash branch April 13, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants