Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version mismatch of aws-sdk-go-v2 #7921

Merged
merged 1 commit into from
May 15, 2024
Merged

Fix version mismatch of aws-sdk-go-v2 #7921

merged 1 commit into from
May 15, 2024

Conversation

seternate
Copy link
Contributor

@seternate seternate commented Apr 29, 2024

Changes

Fix version mismatch of github.com/aws/aws-sdk-go-v2 and github.com/aws/aws-sdk-go-v2/ecr due to a breaking change in aws-sdk-go-v2 of version v1.23.0. The mismatch is caused by the 2 dependencies github.com/sigstore/sigstore/pkg/signature/kms/aws and github.com/google/go-containerregistry using aws-sdk-go-v2 in v.18.x and v1.26.x.

When no command or script was given to a Task, this caused the entrypoint resolve logic to fail with a "401 Not Authorized", when trying to get the manifest from a private AWS ECR.

Fixes #7698

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Fixing "401 Not Authorized" using Image from private AWS ECR without specifying "command" or "script" in Task.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 29, 2024
Copy link

linux-foundation-easycla bot commented Apr 29, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 29, 2024
@tekton-robot
Copy link
Collaborator

Hi @seternate. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 29, 2024
@seternate
Copy link
Contributor Author

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 29, 2024
Fix version mismatch of github.com/aws/aws-sdk-go-v2 and
github.com/aws/aws-sdk-go-v2/ecr due to a breaking change in
aws-sdk-go-v2 of version v1.23.0. The mismatch is caused by the
2 dependencies github.com/sigstore/sigstore/pkg/signature/kms/aws and
github.com/google/go-containerregistry using aws-sdk-go-v2 in v.18.x
and v1.26.x.

When no command or script was given to a Task, this caused the
entrypoint resolve logic to fail with a "401 Not Authorized", when
trying to get the manifest from a private AWS ECR.
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 29, 2024
@chitrangpatel
Copy link
Contributor

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chitrangpatel,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chitrangpatel
Copy link
Contributor

/test pull-tekton-pipeline-alpha-integration-tests

@chitrangpatel
Copy link
Contributor

/test pull-tekton-pipeline-go-coverage-df

@tekton-robot
Copy link
Collaborator

@chitrangpatel: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-beta-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test pull-tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-tekton-pipeline-go-coverage-df

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot merged commit 3722bfe into tektoncd:main May 15, 2024
13 checks passed
@seternate seternate deleted the bump-aws-sdk-ecr-version branch May 20, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entrypoint cannot be found in private repository image
6 participants