Skip to content

Commit

Permalink
Fix version mismatch of aws-sdk-go-v2
Browse files Browse the repository at this point in the history
Fix version mismatch of github.com/aws/aws-sdk-go-v2 and
github.com/aws/aws-sdk-go-v2/ecr due to a breaking change in
aws-sdk-go-v2 of version v1.23.0. The mismatch is caused by the
2 dependencies github.com/sigstore/sigstore/pkg/signature/kms/aws and
github.com/google/go-containerregistry using aws-sdk-go-v2 in v.18.x
and v1.26.x.

When no command or script was given to a Task, this caused the
entrypoint resolve logic to fail with a "401 Not Authorized", when
trying to get the manifest from a private AWS ECR.
  • Loading branch information
seternate authored and tekton-robot committed May 15, 2024
1 parent 19cc5c2 commit 3722bfe
Show file tree
Hide file tree
Showing 92 changed files with 6,400 additions and 1,849 deletions.
6 changes: 6 additions & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,12 @@ require (
gopkg.in/go-jose/go-jose.v2 v2.6.3 // indirect
)

// TODO: Remove this once github.com/google/go-containerregistry uses github.com/aws/aws-sdk-go-v2 >v1.23.0
replace (
github.com/aws/aws-sdk-go-v2/service/ecr => github.com/aws/aws-sdk-go-v2/service/ecr v1.27.3
github.com/aws/aws-sdk-go-v2/service/ecrpublic => github.com/aws/aws-sdk-go-v2/service/ecrpublic v1.23.3
)

require (
cloud.google.com/go/compute v1.24.0 // indirect
contrib.go.opencensus.io/exporter/ocagent v0.7.1-0.20200907061046-05415f1de66d // indirect
Expand Down
8 changes: 4 additions & 4 deletions go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

161 changes: 161 additions & 0 deletions vendor/github.com/aws/aws-sdk-go-v2/service/ecr/CHANGELOG.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 3722bfe

Please sign in to comment.