Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updater artifacts V1 compatible #1239

Merged
merged 4 commits into from
Dec 12, 2024
Merged

fix: updater artifacts V1 compatible #1239

merged 4 commits into from
Dec 12, 2024

Conversation

shanimal08
Copy link
Collaborator

@shanimal08 shanimal08 commented Dec 12, 2024

Description

  • fixes missing release artifacts after Tauri V2 merge:

needed to change createUpdaterArtifacts to v1Compatible for the zips

How Has This Been Tested?

  • beta build branch:

macOs:

image

linux:
image

windows:
image

What process can a PR reviewer use to test or verify this change?

@shanimal08 shanimal08 marked this pull request as ready for review December 12, 2024 10:38
@shanimal08 shanimal08 requested a review from a team as a code owner December 12, 2024 10:38
@brianp brianp merged commit e5e81da into main Dec 12, 2024
20 checks passed
@brianp brianp deleted the build-fix-artifacts branch December 12, 2024 11:20
@brianp
Copy link
Collaborator

brianp commented Dec 12, 2024

I wish I had looked closer. This PR did not produce the artifacts as listed in those images. Those are the artifacts it's looking for. But only 3 single artifacts are produced.
image

@shanimal08
Copy link
Collaborator Author

I wish I had looked closer. This PR did not produce the artifacts as listed in those images. Those are the artifacts it's looking for. But only 3 single artifacts are produced.

image

omg got me too 🙈 i previously removed the bundle.targets value so it'd default to "all" but reverted because mac failed. it worked after retrying though (2nd last commit)

if you add app to bundle.target in the conf it'll add those.

still need v1Compatible though (see builds for windows and linux)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants