Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: individual gpu settings #1067

Merged
merged 15 commits into from
Nov 21, 2024

Conversation

Misieq01
Copy link
Collaborator

@Misieq01 Misieq01 commented Nov 14, 2024

Continuation of #1054

Important note

It Requires versions 0.1.19 of gpuminer. From what i saw release for this version didn't passed so to work with this PR or test it its required to build gpuminer from main locally and replace binaries until version 0.1.19 is released

[ Summary ]

  • Expanded Custom mode modal to take into account multiple gpu devices
  • Expanded and adjusted max_gpu_threads and correlated fields on frontend and backend
  • Fixed parsing gpu_status.json in gpu_miner
  • Changed passed value to grid_size to include multiple gpu devices

[ What is left to do ]

  • Test it on wider range of devices

@Misieq01 Misieq01 marked this pull request as draft November 14, 2024 15:43
@Misieq01 Misieq01 force-pushed the feat/individual-gpu-settings branch from 2a72634 to 1665495 Compare November 19, 2024 13:54
@brianp
Copy link
Collaborator

brianp commented Nov 19, 2024

I know it's still in draft but I was trying it out and saw something funny. Although this time it did appear that the gpuminer was running, and wasn't being restarted.
Screenshot 2024-11-19 151105

@Misieq01 Misieq01 marked this pull request as ready for review November 19, 2024 14:18
@Misieq01
Copy link
Collaborator Author

I know it's still in draft but I was trying it out and saw something funny. Although this time it did appear that the gpuminer was running, and wasn't being restarted. Screenshot 2024-11-19 151105

Oh, good catch, I'll fix it quickly

@Misieq01
Copy link
Collaborator Author

Misieq01 commented Nov 19, 2024

Tested on:
Ubuntu with rtx4080 and integrated amd gpu => Works
Windows with rtx4060 and integrated intel gpu => Works
Apple m1 => Not working ( But from what I see it does not work on any branch )

@Misieq01 Misieq01 force-pushed the feat/individual-gpu-settings branch from 7c66e73 to c4faed6 Compare November 19, 2024 14:45
@brianp brianp merged commit 3a71981 into tari-project:main Nov 21, 2024
9 checks passed
@Tas4tari
Copy link

Tas4tari commented Nov 21, 2024

Tested on Windows 11, app version 0.7.2. In Custome mode, I do see my individual GPU devices however even when adjusting them, my GPU Power still shows as null on the mining widget and I still see warnings in the logs:
Screenshot (307)
Screenshot (308)
Screenshot (310)
Screenshot (309)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants