fix: remove LocaleCode enum #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimeonC
force-pushed
the
drop-localecode-enum
branch
8 times, most recently
from
b228bb8
to
7038850
Compare
This enum often causes tree shaking issues as it’s an Enum Value and it’s only used as a type. Changing in favour of inference based typescript types and an string literal. Disabled useless auditjs check BREAKING CHANGE: LocaleCode enum -> LocaleCode string literal locales.en -> locales.english orderedLocales -> orderedLocaleCodes
SimeonC
force-pushed
the
drop-localecode-enum
branch
from
7038850
to
139e670
Compare
daniellizik
reviewed
Jul 22, 2024
daniellizik
approved these changes
Jul 22, 2024
whanchong
approved these changes
Jul 23, 2024
|
🚀 PR was released in |
tablecheck-public-automation
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enum often causes tree shaking issues as it’s an Enum Value and it’s only used as a type. Changing in favour of inference based typescript types and an string literal.
Disabled useless auditjs check
BREAKING CHANGES:
LocaleCode enum -> LocaleCode string literal
locales.en -> locales.english
orderedLocales -> orderedLocaleCodes
📦 Published PR as canary version:
2.0.0--canary.7.99e624cb6936f29a3f2d413ca47480a589d4d7bb.0✨ Test out this PR locally via:
npm install @tablecheck/locales@2.0.0--canary.7.99e624cb6936f29a3f2d413ca47480a589d4d7bb.0 # or yarn add @tablecheck/locales@2.0.0--canary.7.99e624cb6936f29a3f2d413ca47480a589d4d7bb.0