Skip to content

Commit

Permalink
fix!: remove LocaleCode enum
Browse files Browse the repository at this point in the history
This enum often causes tree shaking issues as it’s an Enum Value and it’s only used as a type. Changing in favour of inference based typescript types and an string literal.

Disabled useless auditjs check

BREAKING CHANGE:
LocaleCode enum -> LocaleCode string literal
locales.en -> locales.english
orderedLocales -> orderedLocaleCodes
  • Loading branch information
SimeonC committed Jun 25, 2024
1 parent ad7c730 commit 7038850
Show file tree
Hide file tree
Showing 25 changed files with 839 additions and 563 deletions.
86 changes: 31 additions & 55 deletions .github/workflows/pull_requests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,69 +49,45 @@ jobs:
cache: npm

- name: Restore npm installs and Lerna setup
run: npm i --legacy-peer-deps
run: npm ci --legacy-peer-deps

- name: Validate all commits from PR
run: npx commitlint --from ${{ github.event.pull_request.base.sha }} --to ${{ github.event.pull_request.head.sha }} --verbose

- name: Run linter
run: npm run lint

audit:
needs: [setup]
runs-on: ubuntu-latest
steps:
- name: Checkout 🛎️
uses: actions/checkout@v2
with:
fetch-depth: 0

- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: ${{ needs.setup.outputs.nvmrc }}
cache: npm

- name: Restore npm installs and Lerna setup
run: npm i --legacy-peer-deps

- name: Audit Dependencies
run: npm run audit:ci
env:
OSSI_USERNAME: ${{ secrets.OSSI_USERNAME }}
OSSI_TOKEN: ${{ secrets.OSSI_TOKEN }}

# test:
# needs: [setup]
# runs-on: ubuntu-latest
# steps:
# - name: Checkout 🛎️
# uses: actions/checkout@v2
# with:
# fetch-depth: 0
#
# - name: Setup Node.js
# uses: actions/setup-node@v2
# with:
# node-version: ${{ needs.setup.outputs.nvmrc }}
# cache: npm
#
# - name: Restore npm installs and Lerna setup
# run: npm i --legacy-peer-deps
#
# - name: Run Tests
# run: npm test
#
# - name: Publish Unit Test Results
# uses: EnricoMi/publish-unit-test-result-action@v1
# if: always()
# with:
# files: junit/**/*.xml
# test:
# needs: [setup]
# runs-on: ubuntu-latest
# steps:
# - name: Checkout 🛎️
# uses: actions/checkout@v2
# with:
# fetch-depth: 0
#
# - name: Setup Node.js
# uses: actions/setup-node@v2
# with:
# node-version: ${{ needs.setup.outputs.nvmrc }}
# cache: npm
#
# - name: Restore npm installs and Lerna setup
# run: npm i --legacy-peer-deps
#
# - name: Run Tests
# run: npm test
#
# - name: Publish Unit Test Results
# uses: EnricoMi/publish-unit-test-result-action@v1
# if: always()
# with:
# files: junit/**/*.xml

release:
runs-on: ubuntu-latest
needs: [audit, lint]
# needs: [test, audit, lint]
needs: [lint]
# needs: [test, lint]
steps:
- name: Checkout 🛎️
uses: actions/checkout@v2
Expand All @@ -129,11 +105,11 @@ jobs:
cache: npm

- name: Install 🔧
run: npm i --legacy-peer-deps
run: npm ci --legacy-peer-deps

- name: Create Canary Release ✨
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
SLACK_TOKEN: ${{ secrets.SLACK_TOKEN }}
run: npx auto shipit --dry-run
run: npx auto shipit
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ jobs:
- name: Install 🔧
run: npm ci --legacy-peer-deps

# - name: Run Tests
# run: npm test
# - name: Run Tests
# run: npm test

- name: Create Release ✨
env:
Expand Down
Loading

0 comments on commit 7038850

Please sign in to comment.