Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(synapse-interface): Removes banner #3384

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

abtestingalpha
Copy link
Collaborator

@abtestingalpha abtestingalpha commented Nov 12, 2024

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted the end date of the Announcement Banner, shortening its display duration by five days.

dc5569e: synapse-interface preview link

Copy link
Contributor

coderabbitai bot commented Nov 12, 2024

Walkthrough

The changes involve a modification to the endDate property of the AnnouncementBanner component within the LandingPageWrapper function. The endDate was updated from November 15, 2024, to November 10, 2024, resulting in a five-day reduction in the announcement's duration. No other modifications were made to the logic, error handling, or control flow within the component.

Changes

File Path Change Summary
packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx Updated endDate in AnnouncementBanner from 2024-11-15 to 2024-11-10

Possibly related PRs

  • Adjusts banner date #2647: The changes in this PR also modify the endDate property of the AnnouncementBanner component within the LandingPageWrapper, indicating a direct connection in the same file and functionality.

Suggested labels

M-synapse-interface, size/xs

Suggested reviewers

  • bigboydiamonds
  • aureliusbtc

🐰 In the meadow, where the banners sway,
A change was made, just five days away.
Shorter the wait, for news to unfold,
A hop, a skip, in the autumn gold.
With each little tweak, we dance and play,
Celebrating changes, hip-hip-hooray! 🌼

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

Error: Failed to load parser '@babel/eslint-parser' declared in 'packages/synapse-interface/.eslintrc.js': Cannot find module '@babel/core/package.json'
Require stack:

  • /node_modules/@babel/eslint-parser/lib/parse.cjs
  • /node_modules/@babel/eslint-parser/lib/index.cjs
  • /node_modules/@eslint/eslintrc/dist/eslintrc.cjs
    at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15)
    at Function.resolve (node:internal/modules/helpers:145:19)
    at Object. (/node_modules/@babel/eslint-parser/lib/parse.cjs:14:19)
    at Module._compile (node:internal/modules/cjs/loader:1546:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1691:10)
    at Module.load (node:internal/modules/cjs/loader:1317:32)
    at Module._load (node:internal/modules/cjs/loader:1127:12)
    at TracingChannel.traceSync (node:diagnostics_channel:315:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
    at Module.require (node:internal/modules/cjs/loader:1339:12)

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 2f1f49e and 5300632.

📒 Files selected for processing (1)
  • packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx (1 hunks)
🔇 Additional comments (1)
packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx (1)

65-65: LGTM! Date format change looks good.

The change to end the World Chain announcement banner 5 days earlier is straightforward and aligns with the PR objective.

Let's verify the date format consistency across the codebase:

✅ Verification successful

Date format is consistent across the codebase

The ISO 8601 date format (YYYY-MM-DDThh:mm:ss+00:00) is consistently used in all banner date properties. The only instances found are in the same component with matching format:

  • startDate: 2024-10-09T18:45:09+00:00
  • endDate: 2024-11-10T18:45:09+00:00
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for consistent date format usage in announcement banners
# Expected format: YYYY-MM-DDThh:mm:ss+00:00

# Search for other date strings in announcement banners
rg -U "new Date\(['\"].*T.*['\"].*\)" --type tsx

Length of output: 82


Script:

#!/bin/bash
# Description: Check for consistent date format usage in announcement banners
# Expected format: YYYY-MM-DDThh:mm:ss+00:00

# Search for other date strings in announcement banners using ripgrep
# Note: Using --type typescript to include .tsx files
rg -U "new Date\(['\"].*T.*['\"].*\)" --type typescript

Length of output: 96


Script:

#!/bin/bash
# Description: Check for consistent date format usage in announcement banners
# Expected format: YYYY-MM-DDThh:mm:ss+00:00

# Search for other date strings in announcement banners
# Using plain ripgrep without file type filtering
rg -U "new Date\(['\"].*T.*['\"].*\)"

# Also search for the file extension to understand what's available
fd "\.(tsx|ts)$"

Length of output: 51194


Script:

#!/bin/bash
# Search for date formats in AnnouncementBanner component
rg -U "new Date\(['\"].*['\"].*\)" packages/synapse-interface/components/Maintenance/components/AnnouncementBanner.tsx

Length of output: 124


Script:

#!/bin/bash
# First, let's check if the file exists and see its content
cat packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx

# Also check for any other date formats in the codebase
rg -U "startDate.*new Date|endDate.*new Date" --type-add 'ts:*.{ts,tsx}' --type ts

Length of output: 10295


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5300632
Status: ✅  Deploy successful!
Preview URL: https://e583a14b.sanguine-fe.pages.dev
Branch Preview URL: https://fe-remove-banner.sanguine-fe.pages.dev

View logs

Copy link

codecov bot commented Nov 12, 2024

Bundle Report

Changes will decrease total bundle size by 3.52MB (-9.87%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sdk-router-@synapsecns/sdk-router-esm 255.26kB 609 bytes (0.24%) ⬆️
sdk-router-@synapsecns/sdk-router-cjs 117.55kB 312 bytes (0.27%) ⬆️
explorer-ui-server-cjs* 724.74kB 141.33kB (-16.32%) ⬇️
explorer-ui-client-array-push* 2.17MB 146.44kB (-6.33%) ⬇️
synapse-interface-client-array-push 7.41MB 132.29kB (1.82%) ⬆️
synapse-interface-server-cjs 1.65MB 160.29kB (10.72%) ⬆️
widget-cjs-esm* 271.27kB 2.03kB (-0.74%) ⬇️
docs-bridge-client-array-push* 7.34MB 564.21kB (-7.14%) ⬇️
docs-bridge-server-cjs* 11.57MB 3.31MB (-22.22%) ⬇️
synapse-constants-esm-cjs* 174.63kB 174.63kB (100%) ⬆️
synapse-constants-cjs-esm* 174.18kB 174.18kB (100%) ⬆️

ℹ️ *Bundle size includes cached data from a previous commit

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.22600%. Comparing base (7eda527) to head (5300632).
Report is 2 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##              master       #3384   +/-   ##
=============================================
  Coverage   34.22600%   34.22600%           
=============================================
  Files            524         524           
  Lines          33495       33495           
  Branches          82          82           
=============================================
  Hits           11464       11464           
  Misses         21016       21016           
  Partials        1015        1015           
Flag Coverage Δ
packages 90.44834% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Deploying sanguine with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5300632
Status: ✅  Deploy successful!
Preview URL: https://58580d89.sanguine.pages.dev
Branch Preview URL: https://fe-remove-banner.sanguine.pages.dev

View logs

@abtestingalpha abtestingalpha merged commit 107e890 into master Nov 12, 2024
39 checks passed
@abtestingalpha abtestingalpha deleted the fe/remove-banner branch November 12, 2024 03:13
@coderabbitai coderabbitai bot mentioned this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant