-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(synapse-interface): Removes banner #3384
Conversation
WalkthroughThe changes involve a modification to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsxOops! Something went wrong! :( ESLint: 8.57.1 Error: Failed to load parser '@babel/eslint-parser' declared in 'packages/synapse-interface/.eslintrc.js': Cannot find module '@babel/core/package.json'
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🔇 Additional comments (1)packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx (1)
The change to end the World Chain announcement banner 5 days earlier is straightforward and aligns with the PR objective. Let's verify the date format consistency across the codebase: ✅ Verification successfulDate format is consistent across the codebase The ISO 8601 date format (
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for consistent date format usage in announcement banners
# Expected format: YYYY-MM-DDThh:mm:ss+00:00
# Search for other date strings in announcement banners
rg -U "new Date\(['\"].*T.*['\"].*\)" --type tsx
Length of output: 82 Script: #!/bin/bash
# Description: Check for consistent date format usage in announcement banners
# Expected format: YYYY-MM-DDThh:mm:ss+00:00
# Search for other date strings in announcement banners using ripgrep
# Note: Using --type typescript to include .tsx files
rg -U "new Date\(['\"].*T.*['\"].*\)" --type typescript
Length of output: 96 Script: #!/bin/bash
# Description: Check for consistent date format usage in announcement banners
# Expected format: YYYY-MM-DDThh:mm:ss+00:00
# Search for other date strings in announcement banners
# Using plain ripgrep without file type filtering
rg -U "new Date\(['\"].*T.*['\"].*\)"
# Also search for the file extension to understand what's available
fd "\.(tsx|ts)$"
Length of output: 51194 Script: #!/bin/bash
# Search for date formats in AnnouncementBanner component
rg -U "new Date\(['\"].*['\"].*\)" packages/synapse-interface/components/Maintenance/components/AnnouncementBanner.tsx
Length of output: 124 Script: #!/bin/bash
# First, let's check if the file exists and see its content
cat packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx
# Also check for any other date formats in the codebase
rg -U "startDate.*new Date|endDate.*new Date" --type-add 'ts:*.{ts,tsx}' --type ts
Length of output: 10295 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Deploying sanguine-fe with Cloudflare Pages
|
Bundle ReportChanges will decrease total bundle size by 3.52MB (-9.87%) ⬇️. This is within the configured threshold ✅ Detailed changes
ℹ️ *Bundle size includes cached data from a previous commit |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3384 +/- ##
=============================================
Coverage 34.22600% 34.22600%
=============================================
Files 524 524
Lines 33495 33495
Branches 82 82
=============================================
Hits 11464 11464
Misses 21016 21016
Partials 1015 1015
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Deploying sanguine with Cloudflare Pages
|
Summary by CodeRabbit
dc5569e: synapse-interface preview link