Nav update #3480
Nav update #3480
Conversation
abtestingalpha
requested review from
bigboydiamonds and
aureliusbtc
as code owners
|
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsxOops! Something went wrong! :( ESLint: 8.57.1 Error: Failed to load parser '@babel/eslint-parser' declared in 'packages/synapse-interface/.eslintrc.js': Cannot find module '@babel/core/package.json'
WalkthroughThis pull request introduces updates to the Synapse interface, focusing on adding a new staking feature for SYN tokens on the Cortex Protocol. The changes include updating the announcement banner, adding a new navigation route for SYN staking, and localizing the new feature across multiple language files. The modifications primarily affect the landing page, navigation constants, and internationalization support. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
packages/synapse-interface/messages/tr.json (1)
338-338: Consider using a more descriptive Turkish translationThe current translation "SYN -> CX" uses technical notation. Consider using a more descriptive Turkish translation that explains the action, similar to how other UI elements are translated in this file.
- "Stake SYN for CX": "SYN -> CX", + "Stake SYN for CX": "CX için SYN Stake Et",packages/synapse-interface/messages/es.json (1)
338-338: Use proper Spanish translation instead of technical notationThe current translation "SYN -> CX" uses technical notation while the rest of the file uses proper Spanish translations. For consistency, consider using a proper Spanish translation.
- "Stake SYN for CX": "SYN -> CX", + "Stake SYN for CX": "Apostar SYN por CX",packages/synapse-interface/messages/fr.json (1)
338-338: Use proper French translation instead of technical notationThe current translation "SYN -> CX" uses technical notation while the rest of the file uses proper French translations (e.g., "Staker"). For consistency, consider using a proper French translation.
- "Stake SYN for CX": "SYN -> CX", + "Stake SYN for CX": "Staker SYN pour CX",
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx(1 hunks)packages/synapse-interface/constants/routes.ts(2 hunks)packages/synapse-interface/constants/urls/index.tsx(1 hunks)packages/synapse-interface/messages/ar.json(1 hunks)packages/synapse-interface/messages/en-US.json(1 hunks)packages/synapse-interface/messages/es.json(1 hunks)packages/synapse-interface/messages/fr.json(1 hunks)packages/synapse-interface/messages/jp.json(1 hunks)packages/synapse-interface/messages/tr.json(1 hunks)packages/synapse-interface/messages/zh-CN.json(1 hunks)
🔇 Additional comments (8)
packages/synapse-interface/constants/routes.ts (2)
11-11: Consider verifying the URL import.
Ensure that the STAKE_SYN_FOR_CX_URL constant is correctly imported from the urls module and doesn't cause undefined references if the file structure changes.
67-71: New nav entry is consistent.
The new Cortex entry aligns well with existing navigation patterns. The text label "Stake SYN for CX" is descriptive and consistent with the feature. Good addition!
packages/synapse-interface/constants/urls/index.tsx (1)
36-36: Ensure domain reliability.
Using a plain external string for the URL is appropriate. However, verify that https://cortexprotocol.com/stake remains valid and secure. Consider wrapping in a config file or environment variable if future updates are expected.
packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx (1)
62-65: Banner dates and content are coherent.
Banner ID, content, start/end dates are updated properly. Verify that these dates match marketing or product timelines, and confirm that the new banner does not overlap with older banners.
packages/synapse-interface/messages/zh-CN.json (1)
338-338: Translation alignment looks accurate.
"Stake SYN for CX" is consistently translated as "SYN -> CX". This is concise and matches the style of short translations in the file. Confirm that these strings are contextually accurate for native speakers.
packages/synapse-interface/messages/jp.json (1)
338-338: Translation looks good!
The Japanese translation "SYN -> CX" appropriately maintains the technical terms and uses a clear arrow symbol, consistent with other language files.
packages/synapse-interface/messages/ar.json (1)
338-338: Translation looks good!
The Arabic translation "$SYN الرهن" correctly uses:
- The appropriate Arabic term "الرهن" for staking
- Proper RTL text direction
- Maintained technical term with currency symbol
packages/synapse-interface/messages/en-US.json (1)
338-338: Translation looks good!
The English text appropriately:
- Maintains technical terms (SYN, CX)
- Uses proper capitalization
- Clearly describes the action (Stake) and the tokens involved
Bundle ReportChanges will decrease total bundle size by 2.89MB (-23.4%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Summary by CodeRabbit
New Features
Localization
Navigation
63f329c: synapse-interface preview link