Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(contracts-rfq): add world scan #3326

Merged
merged 2 commits into from
Oct 24, 2024
Merged

chore(contracts-rfq): add world scan #3326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29e81f5
build: add WC config params
ChiTimesChi Oct 23, 2024
e28c085
chore: add WC deployment
ChiTimesChi Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/contracts-rfq/.env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ SCROLL_RPC=https://rpc.scroll.io
SCROLL_VERIFIER=etherscan
SCROLL_VERIFIER_URL=https://api.scrollscan.com/api
SCROLL_VERIFIER_KEY=YourScrollScanKey
# World Chain
WORLDCHAIN_RPC=https://worldchain-mainnet.g.alchemy.com/public
WORLDCHAIN_VERIFIER=etherscan
WORLDCHAIN_VERIFIER_URL=https://api.worldscan.org/api
WORLDCHAIN_VERIFIER_KEY=YourWorldScanKey
Comment on lines +62 to +64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

World Chain configuration appears to be correct with Alchemy infrastructure

Based on the codebase analysis, the World Chain configuration is legitimate but needs correction:

  1. The chain is properly integrated throughout the codebase using Alchemy's infrastructure (worldchain-mainnet.g.alchemy.com)
  2. The block explorer URL in the codebase consistently points to worldchain-mainnet.explorer.alchemy.com
  3. However, the verifier URL in .env.example (worldscan.org) is inconsistent with the Alchemy infrastructure used everywhere else

Suggested corrections:

  • The WORLDCHAIN_VERIFIER_URL should likely point to Alchemy's API endpoint instead of worldscan.org
  • The verifier configuration should align with Alchemy's block explorer service since that's the infrastructure provider being used across the codebase
🔗 Analysis chain

Verify the World Chain verifier service configuration.

The verifier configuration uses "worldscan.org" which seems unusual. Please verify:

  1. If this is the correct domain for the World Chain block explorer
  2. If the API endpoint is accessible and supports the Etherscan-compatible API

Let me try to gather more information about this configuration by searching for any references to the verifier or World Chain in the codebase.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if this verifier URL is referenced in foundry configuration
rg -l "worldscan.org" --type toml

# Look for any documentation about World Chain
fd -t f "README.md" -X grep -l -i "world.*chain"

Length of output: 82

Script:

#!/bin/bash
# Search for any references to worldscan.org
rg "worldscan.org"

# Search for any references to World Chain or similar terms
rg -i "world.*chain"

# Look for verifier configurations in the contracts-rfq package
fd . packages/contracts-rfq -t f -e json -e js -e ts -X grep -l "verifier"

# Check for environment variable usage related to verifier
rg "WORLDCHAIN_VERIFIER"

Length of output: 8220


# TESTNET CHAINS
# Arbitrum Sepolia
Expand Down
1 change: 1 addition & 0 deletions packages/contracts-rfq/deployments/worldchain/.chainId
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
480
Loading
Loading