Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try splitting modules #30

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

Try splitting modules #30

wants to merge 24 commits into from
+17,593 −20,775

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented May 3, 2022 •
edited
Loading

One of the difficulties of splitting modules is that webidl files make circular references.
For example, dom.idl and html.idl reference each other.

Here is my basic idea to solve the problem without tuning idl files by hands:

  1. Analyze all *.idl files at once
  2. Build a dependency graph against type symbols
  3. Compute SCC to merge only circularly referenced symbols across idl files, then translate it into DAG
  4. Compact the graph by merging by source idl file names as much as possible.

The DAG looks like:
dag

@kateinoigakukun
WebIDLToSwift: Generate into a single file to make the output filenam…
5b44eee 
…es predictable
@kateinoigakukun
Split DOM related support code and generic support snippet
114aa33
@kateinoigakukun
Stop cleaning up generated directory
f95a3e0
@kateinoigakukun
Format only Generated.swift
2216041
@kateinoigakukun
Move Sources/DOMKit/WebIDL/*.swift to Sources/DOMKit/
780073d
@kateinoigakukun
Move hardcoded output path to main.swift
c2bee0a
@kateinoigakukun
Convert webidl to json one-by-one
51ec9fe
@kateinoigakukun
Allow to control behavior by cli arguments
b31b7c4
@kateinoigakukun
WIP
d8e226c
@kateinoigakukun
NFC: Record 'partial' interface while merging
4523a38
@kateinoigakukun
Don't declare protocol when it's partial interface mixin
923e9a3
@kateinoigakukun
WIP
8827cf8
@kateinoigakukun
Allow to generate sources into separate files within a module per idl…
89ecce4 
… file
@kateinoigakukun
Record string literal, closure type, union use for each outputs
1853417
@kateinoigakukun
WIP
87b4e74
@kateinoigakukun
WIP
5b8be21
@kateinoigakukun
Give up typing unions
5bfeaef
@kateinoigakukun
WIP
cb52a3c
@kateinoigakukun
WIP
7e06338
@kateinoigakukun
WIP
c624622
@kateinoigakukun
WIP
63914f8
@kateinoigakukun
Repair build
76a6e25
@kateinoigakukun
WIP
4335637
@kateinoigakukun
Setup tests
b4673fb
@MaxDesiatov
Copy link
Contributor

I'm going to put my PRs on hold until you're done with this one, again sorry about the conflicts 😅

@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented May 3, 2022 •
edited
Loading

There was a lot more work and issues than I originally envisioned, so this PR is not meant to be merged in a near day. This is just for call for advice hehe. So this doesn't block the merge of other PRs

@MaxDesiatov MaxDesiatov mentioned this pull request Aug 21, 2022
Merged
MaxDesiatov added a commit that referenced this pull request Aug 27, 2022
@MaxDesiatov
Split WebAPIKit into modules manually (#46)
ef2d1ca 
New `Module` type is added that specifies dependencies between modules manually.

More advanced approaches could be implemented in the future. For example, automated dependency resolution as investigated in #30.

Partially resolves #14.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kateinoigakukun @MaxDesiatov