Split WebAPIKit into modules manually #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New `Module` type is added that specifies dependencies between modules manually.
MaxDesiatov
commented
Aug 21, 2022
| @@ -1,20 +1,48 @@ | |||
| // swift-tools-version:5.3 | |||
| // swift-tools-version:5.5 | |||
There was a problem hiding this comment.
Bumped due to use of async in the codebase.
MaxDesiatov
commented
Aug 21, 2022
| // The swift-tools-version declares the minimum version of Swift required to build this package. | ||
|
|
||
| import PackageDescription | ||
|
|
||
| let package = Package( | ||
| name: "WebAPIKit", | ||
| platforms: [.macOS(.v10_13)], |
There was a problem hiding this comment.
Bumped due to use of certain file APIs in codegen sources.
This comment was marked as outdated.
This comment was marked as outdated.
MaxDesiatov
commented
Aug 27, 2022
| import WebIDL | ||
|
|
||
| @dynamicMemberLookup | ||
| enum ModuleState { |
There was a problem hiding this comment.
Context renamed to ModuleState here.
MaxDesiatov
commented
Aug 27, 2022
| } | ||
| } | ||
|
|
||
| struct ScopedState { |
There was a problem hiding this comment.
Old Context.State becomes ScopedState here.
kateinoigakukun
approved these changes
Aug 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
Moduletype is added that specifies dependencies between modules manually.More advanced approaches could be implemented in the future. For example, automated dependency resolution as investigated in #30.
Partially resolves #14.