Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new dependencies #147

Merged
merged 5 commits into from
Nov 25, 2024
Merged

added new dependencies #147

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3c7c57a
added new dependencies
Abinash-bit Nov 23, 2024
886ec05
Adding minimum versions
Abinash-bit Nov 25, 2024
d4ad7db
Update pyproject.toml
nabobalis Nov 25, 2024
f4acfd5
Merge branch 'main' into new-dependencies
nabobalis Nov 25, 2024
8b6818b
Changing the pytest.ini file
Abinash-bit Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 29 additions & 21 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "sunkit_instruments"
description = "A SunPy-affiliated package for solar instrum"
description = "A SunPy-affiliated package for solar instruments"
requires-python = ">=3.10"
readme = { file = "README.rst", content-type = "text/x-rst" }
license = { file = "licenses/LICENSE.rst" }
Expand All @@ -18,6 +18,13 @@ authors = [
dependencies = [
"sunpy[map,net,timeseries,visualization]>=6.0.0",
"xarray>=2023.12.0",
"astropy",
Copy link
Contributor

@nabobalis nabobalis Nov 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will all need minimum version like xarray and sunpy do above.

I would compare the versions to what sunpy uses, that would make things simpler.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So You are suggesting that the , i will mention minimum version of below mentioned dependencies!! like sunpy and xarray?!

astropy
packaging
scipy
numpy
h5py
matplotlib
pandas

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please.

"packaging",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this one? Does it not come with pip these days?

Copy link
Contributor Author

@Abinash-bit Abinash-bit Nov 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one refers to packaging right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah just that one.

"scipy",
"numpy",
"h5py",
"matplotlib",
"pandas",
]
dynamic = ["version"]

Expand All @@ -37,6 +44,7 @@ docs = [
"sphinx-changelog",
"sphinx-gallery",
]

[project.urls]
repository = "https://sunpy.org"

Expand All @@ -51,22 +59,22 @@ exclude = ["sunkit_instruments._dev*"]
[tool.setuptools_scm]
write_to = "sunkit_instruments/_version.py"

[ tool.gilesbot ]
[ tool.gilesbot.circleci_artifacts ]
[tool.gilesbot]
[tool.gilesbot.circleci_artifacts]
enabled = true

[ tool.gilesbot.pull_requests ]
[tool.gilesbot.pull_requests]
enabled = true

[ tool.gilesbot.towncrier_changelog ]
[tool.gilesbot.towncrier_changelog]
enabled = true
verify_pr_number = true
changelog_skip_label = "No Changelog Entry Needed"
help_url = "https://github.com/sunpy/sunkit-instruments/blob/main/changelog/README.rst"

changelog_missing_long = "There isn't a changelog file in this pull request. Please add a changelog file to the `changelog/` directory following the instructions in the changelog [README](https://github.com/sunpy/sunkit-instruments/blob/main/changelog/README.rst)."

type_incorrect_long = "The changelog file you added is not one of the allowed types. Please use one of the types described in the changelog [README](https://github.com/sunpy/sunkit-instruments/blob/main/changelog/README.rst)"
type_incorrect_long = "The changelog file you added is not one of the allowed types. Please use one of the types described in the changelog [README](https://github.com/sunpy/sunkit-instruments/blob/main/changelog/README.rst)."

number_incorrect_long = "The number in the changelog file you added does not match the number of this pull request. Please rename the file."

Expand All @@ -88,26 +96,26 @@ write_to = "sunkit_instruments/_version.py"
showcontent = true

[[tool.towncrier.type]]
directory = "removal"
name = "Deprecations and Removals"
showcontent = true
directory = "removal"
name = "Deprecations and Removals"
showcontent = true

[[tool.towncrier.type]]
directory = "feature"
name = "Features"
showcontent = true
directory = "feature"
name = "Features"
showcontent = true

[[tool.towncrier.type]]
directory = "bugfix"
name = "Bug Fixes"
showcontent = true
directory = "bugfix"
name = "Bug Fixes"
showcontent = true

[[tool.towncrier.type]]
directory = "doc"
name = "Improved Documentation"
showcontent = true
directory = "doc"
name = "Improved Documentation"
showcontent = true

[[tool.towncrier.type]]
directory = "trivial"
name = "Trivial/Internal Changes"
showcontent = true
directory = "trivial"
name = "Trivial/Internal Changes"
showcontent = true
Loading