added new dependencies #147
Conversation
|
What is that check_pyproject.toml file doing? |
pyproject.toml
Outdated
| @@ -18,6 +18,13 @@ authors = [ | |||
| dependencies = [ | |||
| "sunpy[map,net,timeseries,visualization]>=6.0.0", | |||
| "xarray>=2023.12.0", | |||
| "astropy", | |||
There was a problem hiding this comment.
These will all need minimum version like xarray and sunpy do above.
I would compare the versions to what sunpy uses, that would make things simpler.
There was a problem hiding this comment.
So You are suggesting that the , i will mention minimum version of below mentioned dependencies!! like sunpy and xarray?!
astropy
packaging
scipy
numpy
h5py
matplotlib
pandas
That was a script i have written to check the lint syntax of .toml file . |
pyproject.toml
Outdated
| @@ -18,6 +18,13 @@ authors = [ | |||
| dependencies = [ | |||
| "sunpy[map,net,timeseries,visualization]>=6.0.0", | |||
| "xarray>=2023.12.0", | |||
| "astropy", | |||
| "packaging", | |||
There was a problem hiding this comment.
Do we need this one? Does it not come with pip these days?
There was a problem hiding this comment.
This one refers to packaging right?
|
Looks like there is a warning that the oldestdeps is now raising: |
|
There is an issue with codecov/project CI how can i proceed further? |
|
That is just codecov being broken, it is safe to ignore. |
|
Thanks @Abinash-bit |
PR Description
Fixes #134
Changes Made: