Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add outputs to Azure README #81

Merged
merged 2 commits into from
May 8, 2024
Merged

docs: Add outputs to Azure README #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c9aca1
Add outputs to Azure README
jiangpengcheng May 8, 2024
409b800
Update main README
jiangpengcheng May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,31 @@ module "sn-managed-cloud" {
module.azure-sn-cloud-manager
]
}

output "client_id" {
value = module.sn-managed-cloud.sn_automation_client_id
description = "The client ID of the sn automation service principal for StreamNative Cloud automation"
}

output "support_client_id" {
value = module.sn-managed-cloud.sn_support_client_id
description = "The client ID of the sn support service principal for StreamNative Cloud support access"
}

output "subscription_id" {
value = module.sn-managed-cloud.subscription_id
description = "The subscription ID of the AKS cluster"
}

output "tenant_id" {
value = module.sn-managed-cloud.tenant_id
description = "The tenant ID of the AKS cluster"
}

output "resource_group_name" {
value = module.sn-managed-cloud.resource_group_name
description = "The name of the resource group where the AKS cluster will be created"
}
```

## Examples
Expand Down
25 changes: 25 additions & 0 deletions modules/azure/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,31 @@ module "azure-managed-cloud" {
module.azure-sn-cloud-manager
]
}

output "client_id" {
value = module.azure-managed-cloud.sn_automation_client_id
description = "The client ID of the sn automation service principal for StreamNative Cloud automation"
}

output "support_client_id" {
value = module.azure-managed-cloud.sn_support_client_id
description = "The client ID of the sn support service principal for StreamNative Cloud support access"
}

output "subscription_id" {
value = module.azure-managed-cloud.subscription_id
description = "The subscription ID of the AKS cluster"
}

output "tenant_id" {
value = module.azure-managed-cloud.tenant_id
description = "The tenant ID of the AKS cluster"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could share the tenant concept of AKS?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a tenant represents a dedicated and trusted instance of Azure Active Directory, identities (person, company, organization, service principle, etc...) need to be created in a tenant.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

customer should already know this concept if they are using Azure

}

output "resource_group_name" {
value = module.azure-managed-cloud.resource_group_name
description = "The name of the resource group where the AKS cluster will be created"
}
```

To run the example, execute the following commands:
Expand Down
Loading