Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add outputs to Azure README #81

Merged
merged 2 commits into from
May 8, 2024
Merged

docs: Add outputs to Azure README #81

merged 2 commits into from
May 8, 2024

Conversation

jiangpengcheng
Copy link
Member

No description provided.

@jiangpengcheng jiangpengcheng requested a review from a team as a code owner May 8, 2024 02:37
@jiangpengcheng jiangpengcheng changed the title Add outputs to Azure README docs: Add outputs to Azure README May 8, 2024
maxsxu
maxsxu previously approved these changes May 8, 2024
Copy link
Member

@maxsxu maxsxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add this to the main README.md too?

freeznet
freeznet previously approved these changes May 8, 2024

output "tenant_id" {
value = module.azure-managed-cloud.tenant_id
description = "The tenant ID of the AKS cluster"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could share the tenant concept of AKS?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a tenant represents a dedicated and trusted instance of Azure Active Directory, identities (person, company, organization, service principle, etc...) need to be created in a tenant.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

customer should already know this concept if they are using Azure

@jiangpengcheng jiangpengcheng dismissed stale reviews from freeznet and maxsxu via 409b800 May 8, 2024 08:35
@nlu90 nlu90 merged commit a300c86 into main May 8, 2024
3 checks passed
@nlu90 nlu90 deleted the update_azure_readme branch May 8, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants