Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the hoodie ci s3 test failed. #446

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/pr-unit-tests-jdk17.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,16 @@ jobs:
run: mvn -ntp -B spotbugs:check

- name: unit test after build
env:
zymap marked this conversation as resolved.
Show resolved Hide resolved
run: mvn test -Pcloud -Dtest="!org.apache.pulsar.ecosystem.io.lakehouse.sink.hudi.HoodieTestS3Cloud"

- name: cloud test after build
if: github.event_name == 'push'
env:
CLOUD_BUCKET_NAME: ${{ secrets.CLOUD_BUCKET_NAME }}
AWS_SECRET_KEY: ${{ secrets.AWS_SECRET_KEY }}
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
run: mvn test -Pcloud
run: mvn test -Pcloud -Dtest='org.apache.pulsar.ecosystem.io.lakehouse.sink.hudi.HoodieTestS3Cloud'

- name: package surefire artifacts
if: failure()
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.pulsar.ecosystem.io.lakehouse.sink.hudi;

import org.testng.annotations.DataProvider;

public class HoodieTestS3Cloud extends HoodieWriterTest {

private static final String STORAGE_S3 = "S3";

@DataProvider(name = "storage")
public Object[][] storageType() {
return new Object[][]{
{STORAGE_S3}
};
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -67,17 +67,14 @@ public class HoodieWriterTest {

private static final Path PROJECT_DATA = FileSystems.getDefault().getPath("data").toAbsolutePath();
private static final String STORAGE_LOCAL = "LOCAL";
private static final String STORAGE_S3 = "S3";
private static final String STORAGE_GCS = "GCS";

private URI testPath;
private SinkConnectorConfig sinkConfig;

@DataProvider(name = "storage")
public Object[][] storageType() {
return new Object[][]{
{STORAGE_LOCAL},
{STORAGE_S3}
{STORAGE_LOCAL}
};
}

Expand Down